Skip to content

Commit

Permalink
Merge pull request #2730 from ControlSystemStudio/CSSTUDIO-1950
Browse files Browse the repository at this point in the history
CSSTUDIO-1950 Remove calls to `fireItemDataConfigChanged()` when archivers are removed from instances of `PVItem`.
  • Loading branch information
abrahamwolk authored Jul 10, 2023
2 parents f6ace83 + 65b745a commit 147815d
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,11 @@ public void addArchiveDataSource(final ArchiveDataSource archs[])
/** @param archive Archive to remove as a source from this item. */
public void removeArchiveDataSource(final ArchiveDataSource archive)
{
// Archive removed -> (Probably) no need to get new data
if (archives.remove(archive))
boolean change = archives.remove(archive);
if (!Preferences.use_default_archives && change) {
// Archive removed -> (Probably) no need to get new data
fireItemDataConfigChanged(false);
}
}

/** @param archs Archives to remove as a source from this item. Ignored when not used. */
Expand All @@ -254,7 +256,7 @@ public void removeArchiveDataSource(final List<ArchiveDataSource> archs)
for (ArchiveDataSource archive : archs)
if (archives.remove(archive))
change = true;
if (change)
if (!Preferences.use_default_archives && change)
fireItemDataConfigChanged(false);
}

Expand Down

0 comments on commit 147815d

Please sign in to comment.