rancher - use vz instead of qemu on M3 macOS >=13.3 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb-dod
changed the title
vanzin
approved these changes
Jan 16, 2024
lib/utils/arch.sh
Outdated
Comment on lines
31
to
35
| if [[ "$hw_model" == *"M3"* ]]; then | ||
| return 0 # This is an M3 Mac. | ||
| else | ||
| return 1 # This is not an M3 Mac. | ||
| fi |
There was a problem hiding this comment.
This could just be.
Suggested change
| if [[ "$hw_model" == *"M3"* ]]; then | |
| return 0 # This is an M3 Mac. | |
| else | |
| return 1 # This is not an M3 Mac. | |
| fi | |
| [[ "$hw_model" == *"M3"* ]] |
There was a problem hiding this comment.
Ah nice, fixed: 1bf73db
pb-dod
commented
Jan 16, 2024
| @@ -120,6 +133,18 @@ function ih::setup::core.rancher::install() { | |||
| fi | |||
| fi | |||
|
|
|||
| # Use vz (requires macOS >=13.3) instead of qemu on M3 macs to resolve issues. | |||
| # More details: https://github.com/lima-vm/lima/issues/1996 | |||
| if ih::arch::is_m3_mac; then | |||
There was a problem hiding this comment.
Planning to only make this switch for m3 mac users for now, since vz is still "experimental" according to the docs. I think a few of the platform team people are going to try using it on non-M3 macs and see if it breaks anything.
|
@mabel-luo confirmed this fix worked for her. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rancher 1.12.0 has a known issue causing m3 macs not to work with qemu:
@mabel-luo recently had to switch from qemu to vz manually after encountering this issue: rancher-sandbox/rancher-desktop#5943 (comment)
This PR automatically switches the development profile from qemu to vz if the user is on at least macOS 13.3 and an M3 mac.