Skip to content

Commit

Permalink
mac os in comments -> macOS, maximize usage of PLIST_DST
Browse files Browse the repository at this point in the history
  • Loading branch information
pb-dod committed Jan 16, 2024
1 parent e26b284 commit ca8d93e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/core/rancher/step.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function ih::setup::core.rancher::test() {
return 1
fi

# Use vz instead of qemu on mac os 13.3 to resolve m3 mac issues.
# Use vz instead of qemu on macOS 13.3 to resolve m3 mac issues.
# See: https://github.com/lima-vm/lima/issues/1996
# Also: https://github.com/rancher-sandbox/rancher-desktop/blob/fcffd3cc071a9414dcf03c895792b5142116ffd4/pkg/rancher-desktop/main/commandServer/settingsValidator.ts#L320-L330
local macos_version=$(ih::arch::get_macos_version)
Expand All @@ -76,7 +76,7 @@ function ih::setup::core.rancher::install() {

echo "A configuration file for Rancher Desktop will be copied to your system"
echo "You may be required to enter your password"
sudo cp "${THIS_DIR}/io.rancherdesktop.profile.defaults.plist" "$HOME/Library/Preferences/io.rancherdesktop.profile.defaults.plist"
sudo cp "${THIS_DIR}/io.rancherdesktop.profile.defaults.plist" "$PLIST_DST"

# Check if Rancher was installed manually
brew list rancher >/dev/null 2>&1
Expand Down Expand Up @@ -133,7 +133,7 @@ function ih::setup::core.rancher::install() {
fi
fi

# Use vz instead of qemu on mac os 13.3 to resolve m3 mac issues.
# Use vz instead of qemu on macOS 13.3 to resolve m3 mac issues.
local macos_version=$(ih::arch::get_macos_version)
if (( $(echo "$macos_version >= 13.3" | bc -l) )); then
if ! grep -q "<string>vz</string>" "$PLIST_DST"; then
Expand Down

0 comments on commit ca8d93e

Please sign in to comment.