Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Solidity 0.8.22 #234

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Support for Solidity 0.8.22 #234

merged 4 commits into from
Oct 31, 2023

Conversation

blitz-1306
Copy link
Contributor

@blitz-1306 blitz-1306 commented Oct 26, 2023

Changes

  • Updated dependencies.
  • Added support of Solidity 0.8.22 on compiler level.
  • Tweaked affected components due to introduced feature of file-level EventDefinitions (SourceUnit, InferType, resolving, AST writing and file-level definitions parser).
  • Updated test snapshots.

Notes

I did not discovered any breaking changes when updating Scribble (see Consensys/scribble#251), so we can release a patch version of the package soon.

Related links

Regards.

@blitz-1306 blitz-1306 added the enhancement New feature or request label Oct 26, 2023
@blitz-1306 blitz-1306 requested a review from cd1m0 October 26, 2023 06:52
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #234 (8fdc8af) into master (0098ccc) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   91.62%   91.59%   -0.03%     
==========================================
  Files         267      267              
  Lines        6625     6630       +5     
  Branches     1352     1353       +1     
==========================================
+ Hits         6070     6073       +3     
- Misses        290      291       +1     
- Partials      265      266       +1     
Files Coverage Δ
src/ast/definitions.ts 86.95% <ø> (ø)
src/ast/implementation/meta/source_unit.ts 96.77% <100.00%> (+0.16%) ⬆️
src/ast/writing/ast_mapping.ts 93.36% <100.00%> (ø)
src/compile/constants.ts 100.00% <ø> (ø)
src/types/infer.ts 83.49% <0.00%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Small nits to fix

@blitz-1306 blitz-1306 requested a review from cd1m0 October 31, 2023 10:27
Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cd1m0 cd1m0 merged commit fd41905 into master Oct 31, 2023
3 checks passed
@cd1m0 cd1m0 deleted the support-solidity-0822 branch October 31, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants