Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AND-52 Seed import/export #123

Merged
merged 16 commits into from
Sep 18, 2024
Merged

AND-52 Seed import/export #123

merged 16 commits into from
Sep 18, 2024

Conversation

zaiatsartem
Copy link
Contributor

Purpose

Private key import/export

Changes

  • Ability to reveal the wallet private key for those having no ability to reveal the seed phrase
  • Ability to use Wallet private key to restore a wallet
  • Update UI in Recovery Wallet screen
  • Add info popups

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Radiokot Radiokot self-requested a review September 17, 2024 15:24
@Radiokot
Copy link
Member

The key input field in its minimum height is slightly taller than it must be
image

@Radiokot
Copy link
Member

The content of the key input screen is not scrollable and can go below the Continue button. In this example I use split screen, but it could also happen when a tall soft keyboard is opened
image

Radiokot
Radiokot requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see comments in files and in the discussion

Radiokot
Radiokot requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@zaiatsartem zaiatsartem merged commit ca2a9a8 into main Sep 18, 2024
1 check passed
@Radiokot Radiokot deleted the feature/AND-52-seed-import-export branch September 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radiokot Radiokot Radiokot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaiatsartem @Radiokot