-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol version 7 update proposal #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various suggestions (and only suggestions, I don't yet have the competences to truly question anything in this document).
General question: Any reason why these protocol updates aren't using Markdown? It'd be easier to read/format them (especially here on GitHub) and it'd be simple to insert images like diagrams and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also change the hashing structure of the block hash preparing for a light client as part of this protocol update, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This specification needs to be hashed and signed as part of the protocol chain update. We could have used markdown, but it makes the hashing of the document a bit more complex with external resources and so on. |
I would say you could just as easily hash the Markdown file itself, just as a .txt file, excluding any external things linked (like images), which could be considered non-normative. Markdown looks pretty similar regardless of what you use to render it and as mentioned GitHub automatically lets you see the rendered Markdown and we use GitHub so... just kinda makes sense to me 😅. Anyways, I won't press this further if it is not desirable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I caught 3 instances of baker instead of validator. Apart from that, my only other comment is what I posted in slack: should we be mentioning here the cool-down time changes that we will do and undo when updating the protocol?
Purpose
Define the specification for the protocol version 7 update.
Changes
Checklist
hard-to-understand areas.