Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sponsored transaction mechanism to Cis2_multi contract #369

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Add sponsored transaction mechanism to Cis2_multi contract #369

merged 6 commits into from
Nov 28, 2023

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Nov 27, 2023 •
edited
Loading

Purpose

Addresses #367

Add sponsored transaction mechanism to Cis2_multi contract.

Changes

  • Add sponsored transaction mechanism.
  • Mint function logic was changed to airdrop a specific amount of tokens to the invoker. Anyone can invoke the function. The metaData URL in the input parameter of the mint function is ignored except for the first time a token_id is minted.

@DOBEN DOBEN changed the title WIP: Cis2_multi_sponsored_txs Add sponsored transaction mechanism to Cis2_multi contract Nov 27, 2023
abizjak
abizjak approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I added a task to make a concordium-cis3 library to make it simpler to add sponsoring to a contract.

But it needs some design thinking so we should not do it now. We can simplify after we have it later.

examples/cis2-multi/src/lib.rs Outdated Show resolved Hide resolved
examples/cis2-multi/src/lib.rs Outdated Show resolved Hide resolved
examples/cis2-multi/src/lib.rs Outdated Show resolved Hide resolved
examples/cis2-multi/src/lib.rs Show resolved Hide resolved
examples/cis2-multi/src/lib.rs Outdated Show resolved Hide resolved
examples/cis2-multi/src/lib.rs Outdated Show resolved Hide resolved
examples/cis2-multi/src/lib.rs Outdated Show resolved Hide resolved
annenkov
annenkov approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@annenkov annenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just left one question.

examples/cis2-multi/src/lib.rs Show resolved Hide resolved
@DOBEN DOBEN merged commit 1737a0d into main Nov 28, 2023
127 checks passed
@DOBEN DOBEN deleted the cis2_multi_sponsored_tx branch November 28, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annenkov annenkov annenkov approved these changes

@abizjak abizjak abizjak approved these changes

@Bargsteen Bargsteen Awaiting requested review from Bargsteen

@limemloh limemloh Awaiting requested review from limemloh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOBEN @abizjak @annenkov