-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating cis3 signatures in test case #359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
force-pushed
the
generating-cis3-signatures-in-test-case
branch
from
November 10, 2023 09:43
25511ad
to
0dc9149
Compare
abizjak
suggested changes
Nov 12, 2023
Bargsteen
suggested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good that you added the tests, but as Ales also pointed out, it is not clear why the tests with generated keys also use the dummy constants. Please explain and/or fix that 😊
DOBEN
force-pushed
the
generating-cis3-signatures-in-test-case
branch
from
November 20, 2023 11:40
89a385c
to
645e074
Compare
I added the following explanation:
|
Bargsteen
approved these changes
Nov 21, 2023
limemloh
approved these changes
Nov 22, 2023
Co-authored-by: Emil Holm Gjørup <[email protected]>
abizjak
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some of the test cases from cis3 haven't been migrated yet. Migrating some of them. In addition, add test cases that showcase how to generate account signatures within a test case (meaning how to create keypairs and how to use the signing function).
Changes
test_inside_signature_permit_transfer
test_outside_signature_permit_transfer
test_inside_signature_permit_update_operator
test_outside_signature_permit_update_operator