Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export AccountKeys #358

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Re-export AccountKeys #358

merged 3 commits into from
Nov 8, 2023

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Nov 7, 2023 •
edited
Loading

Purpose

To generate signatures in the test cases of the sponsored transaction example, we need to use the AccountKeys type.

Changes

  • Re-export AccountKeys type.
  • Fix CI pipeline by increasing Rust version.

@DOBEN DOBEN requested a review from abizjak November 7, 2023 16:17
Bargsteen
Bargsteen approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Bargsteen Bargsteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊
Which error did you see with 1.66? Perhaps one of the external dependencies has bumped its MSRV.

@DOBEN
Copy link
Member Author

DOBEN commented Nov 8, 2023

LGTM 😊 Which error did you see with 1.66? Perhaps one of the external dependencies has bumped its MSRV.

Exactly

error: package `toml_datetime v0.6.5` cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.66.1
Either upgrade to rustc 1.67 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `toml_datetime` supporting rustc 1.66.1
Error: Process completed with exit code 101.

@DOBEN DOBEN merged commit bc7e7ae into main Nov 8, 2023
131 checks passed
@DOBEN DOBEN deleted the re-export-types branch November 8, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bargsteen Bargsteen Bargsteen approved these changes

@abizjak abizjak abizjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOBEN @abizjak @Bargsteen