-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support protocol 7 API changes #198
Support protocol 7 API changes #198
Conversation
What's currently missing is addressing the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Be sure to update the changelog.
@td202 I think you should probably merge your PR on base first (Concordium/concordium-base#534) as this depends on that through the submodule. |
Please update the Node version compatibility version in the readme as well |
@limemloh how do I know which version is the new compatible one? |
…s and added lots of deprecation allowances to account for the deprecations in base.
…calculation can be removed
Co-authored-by: Emil Holm Gjørup <[email protected]>
Purpose
Addresses #192.
Changes
I updated the concordium-base submodule to point to this commit from this PR which I understand is related to the API changes. This updated the gRPC API submodule in concordium-base, which allowed me to regenerate the protobuf code. I then naively fixed the errors that resulted from the changed generated code.
Checklist
hard-to-understand areas.