Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protocol 7 API changes #198

Conversation

Victor-N-Suadicani
Copy link
Contributor

@Victor-N-Suadicani Victor-N-Suadicani commented Jun 13, 2024

Purpose

Addresses #192.

Changes

I updated the concordium-base submodule to point to this commit from this PR which I understand is related to the API changes. This updated the gRPC API submodule in concordium-base, which allowed me to regenerate the protobuf code. I then naively fixed the errors that resulted from the changed generated code.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Victor-N-Suadicani Victor-N-Suadicani marked this pull request as ready for review June 25, 2024 08:03
@td202
Copy link
Contributor

td202 commented Jun 26, 2024

What's currently missing is addressing the changes to PoolInfoResponse. In particular, I'd suggest restructuring BakerPoolStatus to match this. That is, baker_equity_capital, delegated_capital, delegated_capital_cap, pool_info and baker_stake_pending_change are moved into a separate ActiveBakerPoolStatus, which is optional (and should be present if and only if the pool_info is present on the PoolInfoResponse).

Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Be sure to update the changelog.

src/v2/conversions.rs Outdated Show resolved Hide resolved
src/v2/conversions.rs Outdated Show resolved Hide resolved
@Victor-N-Suadicani
Copy link
Contributor Author

@td202 I think you should probably merge your PR on base first (Concordium/concordium-base#534) as this depends on that through the submodule.

@limemloh
Copy link
Contributor

Please update the Node version compatibility version in the readme as well

@Victor-N-Suadicani
Copy link
Contributor Author

@limemloh how do I know which version is the new compatible one?

…s and added lots of deprecation allowances to account for the deprecations in base.
CHANGELOG.md Outdated Show resolved Hide resolved
src/v2/conversions.rs Outdated Show resolved Hide resolved
@Victor-N-Suadicani Victor-N-Suadicani merged commit 7453087 into main Jul 1, 2024
4 checks passed
@Victor-N-Suadicani Victor-N-Suadicani deleted the vs/rus-191-support-protocol-7-api-changes-in-the-rust-sdk branch July 1, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants