Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON parameters #95

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Support JSON parameters #95

merged 6 commits into from
Feb 9, 2024

Conversation

limemloh
Copy link
Collaborator

@limemloh limemloh commented Feb 7, 2024

Purpose

Support smart contract parameters in JSON format using the smart contract module schema.
Closes #94

Changes

  • Add WaitUntilFinalized method on ConcordiumClient for waiting for transactions to finalize.
  • Add Parameter.UpdateJson and Parameter.InitJson for constructing parameters for update and init transactions using JSON and smart contract module schemas.
  • Minor changes to FFIError in lib.rs removing some manual From implementations.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@limemloh limemloh marked this pull request as ready for review February 7, 2024 15:08
@limemloh limemloh requested a review from abizjak February 7, 2024 15:10
Copy link

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Minor comments - probably most because of my ignorance of C#, so take it for what it is :-).

examples/UpdateContractMint/Program.cs Show resolved Hide resolved
examples/UpdateContractMint/Program.cs Outdated Show resolved Hide resolved
examples/UpdateContractMint/Program.cs Show resolved Hide resolved
examples/UpdateContractMint/Program.cs Show resolved Hide resolved
examples/UpdateContractMint/Program.cs Outdated Show resolved Hide resolved
examples/UpdateContractMint/Program.cs Outdated Show resolved Hide resolved
@limemloh limemloh merged commit 1cdb1a8 into main Feb 9, 2024
2 checks passed
@limemloh limemloh deleted the json-parameters branch February 9, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JSON (with schema) for constructing parameters
3 participants