-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JSON parameters #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilkywayPirate
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Minor comments - probably most because of my ignorance of C#, so take it for what it is :-).
abizjak
reviewed
Feb 9, 2024
abizjak
reviewed
Feb 9, 2024
limemloh
force-pushed
the
json-parameters
branch
from
February 9, 2024 09:29
76c6896
to
1715518
Compare
limemloh
force-pushed
the
json-parameters
branch
from
February 9, 2024 11:13
978ac86
to
6606014
Compare
abizjak
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support smart contract parameters in JSON format using the smart contract module schema.
Closes #94
Changes
WaitUntilFinalized
method onConcordiumClient
for waiting for transactions to finalize.Parameter.UpdateJson
andParameter.InitJson
for constructing parameters for update and init transactions using JSON and smart contract module schemas.FFIError
inlib.rs
removing some manualFrom
implementations.Checklist
hard-to-understand areas.