Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Init Contract transaction #89

Merged
merged 15 commits into from
Feb 6, 2024
Merged

Add Init Contract transaction #89

merged 15 commits into from
Feb 6, 2024

Conversation

rasmus-kirk
Copy link
Contributor

@rasmus-kirk rasmus-kirk commented Jan 23, 2024 •
edited
Loading

Purpose

Add the Init Contract transaction

Tested example (trx: ec610115f85c95c99ded98296a2ca629469543aa2f7f947c790788c2b47cbe6f)

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@rasmus-kirk rasmus-kirk marked this pull request as ready for review January 23, 2024 15:31
limemloh
limemloh requested changes Jan 24, 2024
View reviewed changes
src/Types/InitName.cs Outdated Show resolved Hide resolved
src/Types/ModuleReference.cs Outdated Show resolved Hide resolved
src/Types/Parameter.cs Show resolved Hide resolved
src/Types/EnergyAmount.cs Show resolved Hide resolved
@limemloh
Copy link
Collaborator

We should also include this transaction in the parsing in AccountTransactionPayload.

Base automatically changed from get-block-items to main January 25, 2024 13:19
This was referenced Jan 26, 2024
Merged
Closed
limemloh
limemloh approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Forgive me, but I have a last round of comments.

examples/InitContract/Program.cs Outdated Show resolved Hide resolved
examples/InitContract/Program.cs Outdated Show resolved Hide resolved
src/Transactions/InitContract.cs Outdated Show resolved Hide resolved
src/Transactions/InitContract.cs Outdated Show resolved Hide resolved
src/Transactions/InitContract.cs Outdated Show resolved Hide resolved
src/Transactions/InitContract.cs Outdated Show resolved Hide resolved
src/Types/ContractName.cs Outdated Show resolved Hide resolved
@rasmus-kirk rasmus-kirk merged commit 580517f into main Feb 6, 2024
2 checks passed
@rasmus-kirk rasmus-kirk deleted the init-contract branch February 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasmus-kirk @limemloh