Fix issue when converting from gRPC Address #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
force-pushed
the
fix-grpc-account-conversion
branch
from
44c9a75
to
71fcd61
Compare
… conversions. Corrected all places where Grpc.AccountAddress was called directly with .ToByteArray, since this will result in a protobuf encoded array instead of just plane as is.
ghost
approved these changes
Jul 24, 2023
added 2 commits
July 24, 2023 09:30
Due to new added integration test a collection attribute is needed to avoid test to run in parallel.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Running the
GetBlockItemStatusexample with the following command causes an exception:Changes
Addresstype to the SDK providedAddresstype.GetBlockItemStatusexample.Since this is not released yet, I have not updated the changelog.