Fix build warnings

.github/workflows/build-test-format.yml

@@ -9,7 +9,7 @@ on:
 
 env:
   RUST_FMT: nightly-2023-04-01-x86_64-unknown-linux-gnu
-  RUST_CLIPPY: 1.68
+  RUST_CLIPPY: 1.73
 
 jobs:
   rustfmt:
@@ -48,7 +48,7 @@ jobs:
       run: cargo build --manifest-path=./rust-bindings/Cargo.toml --release
 
     - name: Test Rust Project
-      run: cargo test --manifest-path=./rust-bindings/Cargo.toml --release        
+      run: cargo test --manifest-path=./rust-bindings/Cargo.toml --release
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
@@ -58,11 +58,12 @@ jobs:
     - name: Restore dependencies
       run: dotnet restore
 
+    - name: Check formatting
+      run: dotnet format --verify-no-changes
+
     - name: Build
-      run: dotnet build --no-restore
+      run: dotnet build --no-restore -warnaserror
 
     - name: Test
       run: dotnet test --filter FullyQualifiedName!~IntegrationTests --no-build --verbosity normal
 
-    - name: Check formatting
-      run: dotnet format --verify-no-changes

examples/DeployModule/Program.cs

@@ -61,15 +61,15 @@ private static async Task Run(DeployModuleOptions o)
 
         // Prepare the transaction for signing.
         var sender = account.AccountAddress;
-        var sequenceNumber = client.GetNextAccountSequenceNumber(sender).Item1;
+        var (sequenceNumber, _) = await client.GetNextAccountSequenceNumberAsync(sender);
         var expiry = Expiry.AtMinutesFromNow(30);
         var preparedTransfer = transferPayload.Prepare(sender, sequenceNumber, expiry);
 
         // Sign the transaction using the account keys.
         var signedTransfer = preparedTransfer.Sign(account);
 
         // Submit the transaction.
-        var txHash = client.SendAccountTransaction(signedTransfer);
+        var txHash = await client.SendAccountTransactionAsync(signedTransfer);
 
         // Print the transaction hash.
         Console.WriteLine($"Successfully submitted transfer transaction with hash {txHash}");

examples/InitContract/Program.cs

@@ -78,15 +78,15 @@ private static async Task Run(InitContractOptions o)
 
         // Prepare the transaction for signing.
         var sender = account.AccountAddress;
-        var sequenceNumber = client.GetNextAccountSequenceNumber(sender).Item1;
+        var (sequenceNumber, _) = await client.GetNextAccountSequenceNumberAsync(sender);
         var expiry = Expiry.AtMinutesFromNow(30);
         var preparedPayload = payload.Prepare(sender, sequenceNumber, expiry, maxEnergy);
 
         // Sign the transaction using the account keys.
         var signedTrx = preparedPayload.Sign(account);
 
         // Submit the transaction.
-        var txHash = client.SendAccountTransaction(signedTrx);
+        var txHash = await client.SendAccountTransactionAsync(signedTrx);
 
         // Print the transaction hash.
         Console.WriteLine($"Successfully submitted init-contract transaction with hash {txHash}");

src/Client/ConcordiumClient.cs

@@ -812,5 +812,8 @@ public Task<QueryResponse<IAsyncEnumerable<BlockItem>>> GetBlockItems(IBlockHash
         return QueryResponse<IAsyncEnumerable<BlockItem>>.From(response, BlockItem.From, token);
     }
 
+    /// <summary>
+    /// Dispose the client
+    /// </summary>
     public void Dispose() => this.Raw.Dispose();
 }

src/Client/RawClient.cs

@@ -714,5 +714,8 @@ private static GrpcChannelOptions SetSchemeIfNotSet(GrpcChannelOptions? channelO
         return channelOptions;
     }
 
+    /// <summary>
+    /// Dispose the RawClient.
+    /// </summary>
     public void Dispose() => this._grpcChannel.Dispose();
 }

src/Crypto/Ed25519SignKey.cs

@@ -83,6 +83,7 @@ public byte[] Sign(byte[] bytes)
         return algorithm.Sign(key, bytes);
     }
 
+    /// <summary> Determines whether one Ed25519SignKey is equal to a second Ed25519SignKey. </summary>
     public bool Equals(Ed25519SignKey? other)
     {
         if (other is null)
@@ -98,5 +99,6 @@ public bool Equals(Ed25519SignKey? other)
         return this._value.SequenceEqual(other._value);
     }
 
+    /// <summary> Get hash code for the Ed25519SignKey. </summary>
     public override int GetHashCode() => Helpers.HashCode.GetHashCodeByteArray(this._value);
 }

src/Crypto/ISigner.cs

@@ -1,5 +1,6 @@
 namespace Concordium.Sdk.Crypto;
 
+/// <summary> Implementers of this interface hold keys for signing data. </summary>
 public interface ISigner
 {
     /// <summary>

src/Helpers/HashCode.cs

@@ -5,6 +5,10 @@ namespace Concordium.Sdk.Helpers;
 /// </summary>
 public static class HashCode
 {
+
+    /// <summary>
+    /// Helper for getting a hash code for a byte array.
+    /// </summary>
     public static int GetHashCodeByteArray(byte[] array)
     {
         unchecked

src/Transactions/ITransactionSigner.cs

@@ -31,7 +31,7 @@ public interface ITransactionSigner
     /// <summary>
     /// Sign a transaction hash.
     /// </summary>
-    /// <param name="bytes">A byte array representing the transaction hash to sign.</param>
+    /// <param name="data">A byte array representing the transaction hash to sign.</param>
     /// <returns>A <see cref="AccountTransactionSignature"/> representing the transaction signature.</returns>
     /// <exception cref="ArgumentException">Unexpected length of a signature returned by the signing.</exception>
     public AccountTransactionSignature Sign(byte[] data);

src/Transactions/RawPayload.cs

@@ -17,5 +17,8 @@ public sealed record RawPayload(byte[] Bytes) : AccountTransactionPayload
     /// </summary>
     internal override PayloadSize Size() => new((uint)this.Bytes.Length);
 
+    /// <summary>
+    /// Get the array of bytes representing this payload.
+    /// </summary>
     public override byte[] ToBytes() => this.Bytes;
 }

src/Transactions/TransactionSigner.cs

@@ -24,9 +24,11 @@ public sealed class TransactionSigner : ITransactionSigner
     public TransactionSigner() =>
         this._signers = new Dictionary<AccountCredentialIndex, Dictionary<AccountKeyIndex, ISigner>>();
 
+    /// <summary> Get the number of signatures this signer can produce.</summary>
     public byte GetSignatureCount()
         => (byte)this._signers.Values.SelectMany(x => x.Values).Count();
 
+    /// <summary> Get credential-key-map of the signer.</summary>
     public ImmutableDictionary<AccountCredentialIndex, ImmutableDictionary<AccountKeyIndex, ISigner>>
         GetSignerEntries() => this._signers
             .Select(

src/Types/AccountAddress.cs

@@ -237,7 +237,10 @@ public static bool TryDeserial(ReadOnlySpan<byte> bytes, out (AccountAddress? Ac
         return true;
     }
 
+    /// <summary> Determines whether one AccountAddress is equal to a second AccountAddress. </summary>
+    /// <remarks> This does not consider two distinct aliases to the same account as equal. </remarks>
     public bool Equals(AccountAddress? other) => other is not null && this._value.SequenceEqual(other._value);
 
+    /// <summary> Get hash code for the AccountAddress. </summary>
     public override int GetHashCode() => Helpers.HashCode.GetHashCodeByteArray(this._value);
 }

src/Types/AccountSequenceNumber.cs

@@ -15,6 +15,9 @@ namespace Concordium.Sdk.Types;
 /// </summary>
 public readonly record struct AccountSequenceNumber
 {
+    /// <summary>
+    /// The number of bytes used to represent this type when serialized.
+    /// </summary>
     public const uint BytesLength = sizeof(ulong);
 
     /// <summary>

src/Types/AccountStakingInfo.cs

@@ -2,6 +2,9 @@
 
 namespace Concordium.Sdk.Types;
 
+/// <summary>
+/// Information related to staking for a specific account.
+/// </summary>
 public interface IAccountStakingInfo { }
 
 internal static class AccountStakingInfo

src/Types/AccountTransactionEffects.cs

@@ -279,6 +279,7 @@ internal IEnumerable<AccountAddress> GetAffectedAccountAddresses()
 /// </summary>
 /// <param name="To">Receiver account.</param>
 /// <param name="Amount">The list of releases. Ordered by increasing timestamp.</param>
+/// <param name="Memo">Additional data attached to the transaction.</param>
 public sealed record TransferredWithSchedule
     (AccountAddress To, IList<(DateTimeOffset, CcdAmount)> Amount, OnChainData? Memo) : IAccountTransactionEffects
 {

src/Types/BakerEvent.cs

@@ -51,6 +51,7 @@ internal static IBakerEvent From(BakerEvent bakerEvent) =>
                 ),
             BakerEvent.EventOneofCase.None =>
                 throw new MissingEnumException<BakerEvent.EventOneofCase>(bakerEvent.EventCase),
+            BakerEvent.EventOneofCase.DelegationRemoved => throw new NotImplementedException(),
             _ => throw new MissingEnumException<BakerEvent.EventOneofCase>(bakerEvent.EventCase)
         };
 }

src/Types/BakerPoolOpenStatus.cs

@@ -2,6 +2,9 @@
 
 namespace Concordium.Sdk.Types;
 
+/// <summary>
+/// The status of the baker pool in regards to delegations.
+/// </summary>
 public enum BakerPoolOpenStatus
 {
     /// <summary>