Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification ttl #227

Merged
merged 12 commits into from
Sep 25, 2024
Merged

Notification ttl #227

merged 12 commits into from
Sep 25, 2024

Conversation

lassemand
Copy link
Collaborator

@lassemand lassemand commented Sep 24, 2024

Purpose

Adding threshold to when a notification is no longer considered valid enough to be sent

Changes

Single function which ensures catchup at start time

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemand lassemand requested review from DOBEN and soerenbf and removed request for DOBEN September 24, 2024 08:53
@lassemand lassemand marked this pull request as draft September 24, 2024 08:58
@lassemand lassemand marked this pull request as ready for review September 24, 2024 09:07
notification-server/src/bin/service.rs Outdated Show resolved Hide resolved
notification-server/src/bin/service.rs Show resolved Hide resolved
notification-server/src/bin/service.rs Outdated Show resolved Hide resolved
notification-server/src/bin/service.rs Outdated Show resolved Hide resolved
notification-server/src/bin/service.rs Show resolved Hide resolved
notification-server/src/bin/service.rs Outdated Show resolved Hide resolved
@lassemand
Copy link
Collaborator Author

lassemand commented Sep 25, 2024

In general I am opposed to using inline comments unless absolutely necessary. This is because it removes readability of the actual source code. I try to do self explanatory code. If you think I need better named variables let me know. I have added docstring providing an overall explanation of the purpose of the method and tried to perform some optimisations on namings.

@lassemand lassemand merged commit 960423e into main Sep 25, 2024
4 checks passed
@lassemand lassemand deleted the lma/MIS-92/notification-ttl branch September 25, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants