-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification ttl #227
Merged
Merged
Notification ttl #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassemand
requested review from
DOBEN and
soerenbf
and removed request for
DOBEN
September 24, 2024 08:53
lassemand
commented
Sep 24, 2024
lassemand
commented
Sep 24, 2024
soerenbf
approved these changes
Sep 24, 2024
DOBEN
reviewed
Sep 25, 2024
In general I am opposed to using inline comments unless absolutely necessary. This is because it removes readability of the actual source code. I try to do self explanatory code. If you think I need better named variables let me know. I have added docstring providing an overall explanation of the purpose of the method and tried to perform some optimisations on namings. |
DOBEN
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding threshold to when a notification is no longer considered valid enough to be sent
Changes
Single function which ensures catchup at start time
Checklist
hard-to-understand areas.