Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics #205

Merged
merged 15 commits into from
Sep 11, 2024
Merged

Metrics #205

merged 15 commits into from
Sep 11, 2024

Conversation

lassemand
Copy link
Collaborator

@lassemand lassemand commented Sep 10, 2024 •
edited
Loading

Purpose

Metrics to be used as part of notification service

Changes

Metrics endpoint added to API
Service adding server for serving the metrics

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemand lassemand changed the title TODO Metrics Sep 10, 2024
@lassemand lassemand marked this pull request as ready for review September 10, 2024 18:40
soerenbf
soerenbf previously approved these changes Sep 11, 2024
View reviewed changes
notification-server/src/bin/api.rs Outdated Show resolved Hide resolved
notification-server/src/bin/service.rs Show resolved Hide resolved
notification-server/src/bin/service.rs Outdated Show resolved Hide resolved
DOBEN
DOBEN previously approved these changes Sep 11, 2024
View reviewed changes
@lassemand lassemand dismissed stale reviews from DOBEN and soerenbf via 189b21f September 11, 2024 07:28
soerenbf
soerenbf approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lassemand lassemand merged commit bd092db into main Sep 11, 2024
4 checks passed
@lassemand lassemand deleted the lma/MIS-87/notification-service-metrics branch September 11, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soerenbf soerenbf soerenbf approved these changes

@DOBEN DOBEN Awaiting requested review from DOBEN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lassemand @soerenbf @DOBEN