Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ID Verifier and Wallet Connect Test Bench packages #146

Merged
merged 2 commits into from
May 28, 2024

Conversation

lassemoldrup
Copy link
Contributor

Purpose

Closes #110.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our discussion on why there were no more changes needed, it does make sense now:

  • ID verification does not use any of the updated types, and as such have not been subject to breaking changes in that area.
  • Minor version update in test bench should not break anything

@lassemoldrup lassemoldrup merged commit 1fd18ae into main May 28, 2024
18 checks passed
@lassemoldrup lassemoldrup deleted the update-id-verifier-packages branch May 28, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dApps to new web-sdk and wallet-api
2 participants