Align env variables (#209)

* align env variables

* bumped version

* updated args

* fixed makefile

* updated readme

* added setup target

notification-server/Cargo.toml

@@ -2,7 +2,7 @@
 authors = ["Concordium AG [email protected]"]
 edition = "2021"
 name = "notification-server"
-version = "0.2.5"
+version = "0.2.6"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 

notification-server/Makefile

@@ -2,17 +2,19 @@
 
 all: docker-up wait-for-db create-tables
 
+setup: setup-db setup-credentials
+
 setup-db:
 	@echo "Setting default password"
 	@DB_PASSWORD=$$(openssl rand -base64 12) && \
 	export DB_PASSWORD=$$DB_PASSWORD && \
 	cat .env.template | envsubst > .env
 
 setup-credentials:
-	echo "Please enter the path to your Google application credentials file:" && \
+	@echo "Please enter the path to your Google application credentials file:"
 	read GOOGLE_APPLICATION_CREDENTIALS_PATH && \
 	mkdir -p secrets && \
-	cp $$GOOGLE_APPLICATION_CREDENTIALS_PATH secrets/google-credentials.json && \
+	cp $$GOOGLE_APPLICATION_CREDENTIALS_PATH secrets/google-credentials.json
 
 docker-up:
 	@echo "Starting Docker containers..."
@@ -40,4 +42,4 @@ create-tables:
 		docker compose exec -T db psql --username=postgres < $$sql_file; \
 	done
 
-.PHONY: setup all docker-up wait-for-db create-tables
+.PHONY: setup setup-credential setup-db all docker-up wait-for-db create-tables

notification-server/README.md

@@ -1,6 +1,6 @@
-# Notification server
+# Notification api
 
-Server to obtain information about particular account to device mappings and store them in a persistence layer.
+API to obtain information about particular account to device mappings and store them in a persistence layer.
 
 # Notification service
 

notification-server/src/bin/api.rs

@@ -45,6 +45,7 @@ struct Args {
     listen_address: std::net::SocketAddr,
     #[arg(
         long = "prometheus-address",
+        help = "Listen address for the prometheus metrics server.",
         env = "NOTIFICATION_SERVER_PROMETHEUS_ADDRESS"
     )]
     prometheus_address: Option<std::net::SocketAddr>,

notification-server/src/bin/service.rs

@@ -93,9 +93,9 @@ struct Args {
     )]
     block_process_timeout_sec: u64,
     #[arg(
-        long = "listen-address",
-        help = "Listen address for the server.",
-        env = "NOTIFICATION_SERVER_METRICS_LISTEN_ADDRESS"
+        long = "prometheus-address",
+        help = "Listen address for the prometheus metrics server.",
+        env = "NOTIFICATION_SERVER_PROMETHEUS_ADDRESS"
     )]
     listen_address: Option<std::net::SocketAddr>,
 }