Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAV-320 Facilitate message signing #334

Merged
merged 3 commits into from
May 13, 2024
Merged

JAV-320 Facilitate message signing #334

merged 3 commits into from
May 13, 2024

Conversation

Radiokot
Copy link
Member

Purpose

Facilitate message signing (CIS-3, WalletConnect signing) by adding digest generator. For the actual signing, TransactionSigner can be used.

Changes

  • Added MessageSigningDigest class to generate digests for message signing

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Radiokot Radiokot requested review from limemloh and DOBEN May 10, 2024 14:45
@Radiokot Radiokot merged commit 0ac11b7 into main May 13, 2024
2 checks passed
@Radiokot Radiokot deleted the feature/JAV-320-sign-messages branch May 13, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

@limemloh limemloh limemloh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Radiokot @limemloh @DOBEN