Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing endpoints #6

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Implement missing endpoints #6

merged 12 commits into from
Jan 30, 2024

Conversation

magnusbechwind
Copy link
Contributor

@magnusbechwind magnusbechwind commented Dec 11, 2023 •
edited
Loading

Purpose

Implement the missing endpoints: GetBakerEarliestWinTime, GetBakersRewardPeriod, GetBlockCertificates, GetWinningBakersEpoch, and GetFirstBlockEpoch.

Changes

Updated the grpc api. Added EpochRequestBlockHash and EpochRequestRelativeEpoch to types.go and implemented the endpoints mentioned above.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@magnusbechwind magnusbechwind marked this pull request as ready for review December 12, 2023 14:45
abizjak
abizjak reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though you're going to add also add a submodule reference for the grpc-api module.

I don't see that here.

v2/tests/api_test.go Show resolved Hide resolved
v2/types.go Show resolved Hide resolved
v2/types.go Show resolved Hide resolved
v2/getfirstblockepoch.go Outdated Show resolved Hide resolved
v2/getwinningbakersepoch.go Outdated Show resolved Hide resolved
v2/getbakersrewardperiod.go Outdated Show resolved Hide resolved
v2/getbakerearliestwintime.go Outdated Show resolved Hide resolved
@abizjak
Copy link
Contributor

abizjak commented Dec 15, 2023

Also, can you please add some basic examples/tests for the new endpoints.

@abizjak abizjak self-assigned this Jan 30, 2024
@abizjak abizjak merged commit 53e4fc9 into main Jan 30, 2024
1 check passed
@abizjak abizjak deleted the update-go branch January 30, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

Assignees

@abizjak abizjak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusbechwind @abizjak