Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage limit #98

Merged
merged 10 commits into from
Aug 11, 2024
Merged

Update usage limit #98

merged 10 commits into from
Aug 11, 2024

Conversation

benya7
Copy link
Contributor

@benya7 benya7 commented Aug 6, 2024

Purpose

Move checkUsageLimit to the api routes and change usageLimit to hours

Changes

_Describe the changes that were needed.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses some mentioned improvements:
#97

testnet-faucet/src/pages/api/checkUsageLimit.ts Outdated Show resolved Hide resolved
testnet-faucet/src/pages/index.tsx Outdated Show resolved Hide resolved
testnet-faucet/src/pages/api/checkUsageLimit.ts Outdated Show resolved Hide resolved
testnet-faucet/src/pages/api/checkUsageLimit.ts Outdated Show resolved Hide resolved
@benya7 benya7 requested a review from DOBEN August 9, 2024 10:39
testnet-faucet/src/pages/api/validateAndClaim.ts Outdated Show resolved Hide resolved
testnet-faucet/src/pages/api/usageLimit.ts Outdated Show resolved Hide resolved
testnet-faucet/README.md Show resolved Hide resolved
@benya7 benya7 requested a review from DOBEN August 11, 2024 09:49
@DOBEN DOBEN merged commit 9a7cd6b into Concordium:main Aug 11, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants