Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up account selector on main page #561

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

limemloh
Copy link
Contributor

Purpose

Connect account selector on main page with actual data.

Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot for context:

Screenshot 2024-10-30 at 11 10 08

A couple of things:

  • Explicitly named accounts looks... unfortunate, when selected.
    • CCD balance alignment does not match other rows
    • Account name wraps
    • I would discuss with the designer to figure out what to do here, if it's not easily solvable
    • suggestion: text-align: left the text + move selected icon left with position: absolute
  • The rows don't appear clickable when hovering them. Would be nice with an indication that this is the case (at minimum cursor: pointer).
    • Very nice that I can use the keyboard to navigate to each row though! 🎉
  • The scroll bar offsets the entire UI. I would expect only the list to scroll, as I think there is enough space to show a reasonable number of accounts even when subtracting the header of the layout (i.e. fullscreen/connected + 9dots nav button).

Base automatically changed from x-id-cards to browser-ui-update November 1, 2024 12:09
@limemloh limemloh merged commit 3b68429 into browser-ui-update Nov 5, 2024
7 checks passed
@limemloh limemloh deleted the x-account-selector branch November 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants