Display the optional name for ID providers when present #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
force-pushed
the
support-idp-display
branch
from
af4e9ab
to
cba1351
Compare
soerenbf
approved these changes
May 30, 2024
Ivan-Mahda
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Since we soon will have two entries for the same ID provider (one for individuals and one for companies) we need to be able to show different names for these two.
Currently, we display
ipDescription.namewhich needs to match the name on chain, so this can't be tweaked.Changes
metadata.displaywhen present, otherwise fallback to theipDescription.name.metadata.issuanceStartas key in the list of ID providers.