Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO-235] Feature: name accounts #468

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

Ivan-Mahda
Copy link
Contributor

@Ivan-Mahda Ivan-Mahda commented May 13, 2024

Purpose

As a browser wallet user, I want the option to name my accounts.

Changes

Option to edit account name
When Edit icon clicked, User able to edit account name. Name saved in local storage
Changed name displayed across all BrowserWallet

Screenshot 2024-05-13 at 18 00 45 Screenshot 2024-05-13 at 18 01 05

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

Option to edit account name
When Edit icon clicked, User able to edit account name.
Name saved in local storage
Changed name displayed across all BrowserWallet
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern, otherwise looks good 😄

Set input fixed width, to avoid flickering on re-render
@Ivan-Mahda Ivan-Mahda requested a review from limemloh May 16, 2024 08:04
@Ivan-Mahda Ivan-Mahda merged commit f8de3da into main May 28, 2024
7 checks passed
@Ivan-Mahda Ivan-Mahda deleted the PRO-235-feature-name-accounts branch May 28, 2024 14:46
@Ivan-Mahda Ivan-Mahda restored the PRO-235-feature-name-accounts branch May 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants