[BRO-29] Better error reporting in the browser wallet in case TokenMetadata #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadata has an invalid checksum/hash. Changed error message. Now instead of not showing invalid tokens, they displayed in token list with corresponding error. In order to show user, that we found tokens in contract, but they have error. Instead, just not showing them.
…tadata has an invalid checksum/hash. Fix lint error
limemloh
reviewed
May 6, 2024
packages/browser-wallet/src/popup/shared/ContractTokenLine/ContractTokenLine.tsx
Outdated
Show resolved
Hide resolved
…tadata Fix optional params
…tadata Fix optional params
…tadata Fix optional params
soerenbf
approved these changes
May 23, 2024
packages/browser-wallet/src/popup/pages/Account/Tokens/ManageTokens/ManageTokens.tsx
Outdated
Show resolved
Hide resolved
limemloh
approved these changes
May 23, 2024
…tadata Updated CHANGELOG.md Removed optional params
…etter-error-reporting-in-the-browser-wallet-in-case-tokenmetadata-has # Conflicts: # packages/browser-wallet/CHANGELOG.md
Ivan-Mahda
deleted the
BRO-29-better-error-reporting-in-the-browser-wallet-in-case-tokenmetadata-has
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changed error message. Now instead of not showing invalid tokens, they displayed in token list with corresponding error. In order to show user, that we found tokens in contract, but they have error. Instead, just not showing them.
Changes
Error message displayed in token list. Previously it was shown only in console.log
Checklist
hard-to-understand areas.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.