-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BRO-13] Payload decoding in the browser wallet of the CIS3 standard #460
[BRO-13] Payload decoding in the browser wallet of the CIS3 standard #460
Conversation
Proposal on how to decode the payload for the CIS3 contract
Fix typescript types errors
As mentioned in the related issue #279 |
Created signCIS3Message method for explicit CIS3 sign
Revert changes in SignMessage
Created new page for SignCIS3Message
Fix route. Update message description
Adding @soerenbf as reviewer since he is more familiar with the UI part of the wallet than me |
packages/browser-wallet/src/popup/pages/SignCIS3Message/SignCIS3Message.tsx
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/SignCIS3Message/SignCIS3Message.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/SignCIS3Message/SignCIS3Message.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that much about the CIS3 standard; I think @limemloh is better suited to comment on this part (as he already has). It would however be good if you created a small example application under /examples
that uses the functionality.
There is an app /examples/two-step-transfer
which has a pile of different functionality all inlined in a <script>
tag in the html document. You can also find the sponsored transaction example there and adapt it. I would prefer if you created a small isolated (typescript) example though. We usually use vite
to do this.
packages/browser-wallet/src/popup/pages/SignCIS3Message/SignCIS3Message.tsx
Show resolved
Hide resolved
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Update signCIS3Message parameters, for creating CIS3 message. Now full message will be generated at wallet side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
packages/browser-wallet/src/popup/pages/SignCIS3Message/SignCIS3Message.tsx
Outdated
Show resolved
Hide resolved
Are we not doing the example for running this, or what is the resolution on that? |
Yes, after wallet update. I will update example in sponsored transaction Concordium/concordium-dapp-examples#77 |
…S3Message.tsx Co-authored-by: Emil Holm Gjørup <[email protected]>
Update nonce type
Purpose
The browser wallet can also decode the payload field by looking up the parameter schema of the entry_point_name and using this schema to decode the payload. The payload is the input parameter that is sent to the entry_point_name.
Changes
Proposal on how to decode the payload for the CIS3 contract.
Checklist
hard-to-understand areas.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.