Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support web-sdk v7 #396

Closed
wants to merge 1 commit into from
Closed

Support web-sdk v7 #396

wants to merge 1 commit into from

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented Oct 23, 2023

Purpose

This will enable support of newer versions of the web-sdk (v7) without any breaking changes.

Changes

Replace CcdAmount with broader type HasMicroCcd which works with both old and new version of web-sdk.

Context: Since v7 of web-sdk removes methods on CcdAmount it cannot be used with the current released version of the wallet api (helpers), since this uses the old type which require these methods. Since the wallet does not rely on these methods and only on the internal field microCcdAmount of CcdAmount we can support both versions by reflecting this in the type.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

This will enable support of newer versions of the web-sdk (v7).
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Could you bump version to 2.8.1 as well and make the release? If you don't have permission to release on NPM, I can also do that.

@limemloh limemloh requested a review from orhoj October 23, 2023 10:54
@shjortConcordium
Copy link
Contributor

**** you
(No longer seems relevant)

@limemloh limemloh deleted the support-web-sdk-v7 branch September 27, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants