-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade web sdk #395
Merged
Merged
Upgrade web sdk #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
soerenbf
force-pushed
the
upgrade-web-sdk
branch
from
October 19, 2023 06:33
756d83b
to
62f95e3
Compare
@orhoj Prior to releasing a version of the wallet with the SDK upgrade included in this PR, a regression test of some form should be done. |
orhoj
suggested changes
Oct 23, 2023
packages/browser-wallet/src/popup/pages/Account/Earn/Delegate/ConfigureDelegationFlow.tsx
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Account/Earn/RemoveCarousel.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Allowlist/AllowlistEntryView.tsx
Outdated
Show resolved
Hide resolved
soerenbf
force-pushed
the
upgrade-web-sdk
branch
from
October 27, 2023 08:22
7dbb14a
to
fe7f145
Compare
soerenbf
force-pushed
the
upgrade-web-sdk
branch
from
October 27, 2023 08:26
fe7f145
to
11d9690
Compare
orhoj
approved these changes
Oct 31, 2023
Also just caught that the |
soerenbf
force-pushed
the
upgrade-web-sdk
branch
from
October 31, 2023 10:44
361cca7
to
3710e27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade SDK dependency to beta version. I've tested by going through:
Changes
Checklist
hard-to-understand areas.