Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade web sdk #395

Merged
merged 33 commits into from
Oct 31, 2023
Merged

Upgrade web sdk #395

merged 33 commits into from
Oct 31, 2023

Conversation

soerenbf
Copy link
Collaborator

Purpose

Upgrade SDK dependency to beta version. I've tested by going through:

  • Create ID
  • Create account
  • Transfer CCD/wCCD
  • Manage tokens
  • Configure baking/delegation (add, change, remove)
  • Restore wallet
  • Create ID 2.0 proof
  • Add Web3 ID credentials
  • Create Web3 ID proof
  • Wrap/unwrap CCD (wccd.testnet.concordium.com)

Changes

  • Removes JSON RPC
  • Hide GRPC by removing from wallet API interface (legacy version still accessible through implementation layer for compatibility reasons)
  • Add compatibility helpers for wallet API to ensure backwards compatibility with old versions of the API

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf self-assigned this Oct 17, 2023
@soerenbf
Copy link
Collaborator Author

@orhoj Prior to releasing a version of the wallet with the SDK upgrade included in this PR, a regression test of some form should be done.

@soerenbf soerenbf requested a review from orhoj October 25, 2023 14:27
@orhoj
Copy link
Contributor

orhoj commented Oct 31, 2023

Also just caught that the README for the browser-wallet-api-helpers has not been updated to the reflect the changes. We need to remove mentions of JSON-RPC, and it should instead have a description of how to use the new way of connecting through the wallet.

@soerenbf soerenbf merged commit 0b4c9f5 into main Oct 31, 2023
4 checks passed
@soerenbf soerenbf deleted the upgrade-web-sdk branch October 31, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants