Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow allowlisted accounts to connect/requestAccounts without unlocking #373

Closed
wants to merge 5 commits into from

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Remove Unlock/Connect combo for already allowlisted sites.

Changes

  • rename isWhiteListedForAnyAccount to isAllowListedForAnyAccount
  • Remove various locked checks in backgrounds.
  • Add "logged in" guard for external request pages.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

…etMostRecentlySelectedAccount without unlocking
@shjortConcordium shjortConcordium force-pushed the allow-allowlisted-connect-while-locked branch from 46c8a62 to e702aa7 Compare September 1, 2023 08:35
packages/browser-wallet/src/background/index.ts Outdated Show resolved Hide resolved
packages/browser-wallet/src/background/index.ts Outdated Show resolved Hide resolved
packages/browser-wallet/src/background/index.ts Outdated Show resolved Hide resolved
@orhoj orhoj assigned shjortConcordium and unassigned orhoj Sep 1, 2023
@orhoj
Copy link
Contributor

orhoj commented Sep 6, 2023

This change seems to interact poorly with the dapp-libraries, e.g. used in the wCCD webpage. If the wallet is locked and you try to connect, then it doesn't resolve the genesis hash correctly. So there is some aligning to do.

@orhoj orhoj assigned shjortConcordium and unassigned orhoj Sep 6, 2023
orhoj

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants