Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credential metadata fallback #365

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 29, 2023

Purpose

Handle credential metadata being changed (in the contract) to something invalid.

Changes

  • Save the metadata URL that is received when adding the credential, and use this if the credential entry (or the temp metadata url) does not match anything in storage.

Note that we should also be updating the fallback URL everytime we get new valid metadata, but we can add that in the future.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

…erifiableCredentialHooks.tsx

Co-authored-by: Søren Hjort <[email protected]>
@orhoj orhoj merged commit ea91d98 into feature/web3-id Aug 29, 2023
4 checks passed
@orhoj orhoj deleted the add-metadata-fallback branch August 29, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants