Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that credential statements are not empty #360

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 28, 2023

Purpose

Fix an issue where the proof prompt was just a blank screen. This was due to receving a request with no statements, which is not a valid request.

Changes

  • Validate that statements is non-empty.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj
Copy link
Contributor Author

orhoj commented Aug 28, 2023

I update the CHANGELOG for this in #361.

@orhoj orhoj merged commit 5aee208 into feature/web3-id Aug 28, 2023
4 checks passed
@orhoj orhoj deleted the reject-empty-requests branch August 28, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants