Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace json-rpc with grpc in voting dApp #340

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Replace json-rpc with grpc in voting dApp #340

merged 2 commits into from
Aug 17, 2023

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Aug 16, 2023 •
edited
Loading

Purpose

  • JSON-RPC is deprecated and will be eventually removed from all our libraries. This PR migrates the voting dApp.

Changes

  • Replace using jsonRPC with gRPC

@DOBEN DOBEN requested review from bisgardo and abizjak August 16, 2023 15:03
@DOBEN DOBEN force-pushed the replace-json-rpc-with-grpc-in-voting branch from a6744f0 to 92d8b13 Compare August 16, 2023 15:06
bisgardo
bisgardo approved these changes Aug 16, 2023
View reviewed changes
examples/voting/package.json Show resolved Hide resolved
@DOBEN DOBEN merged commit 0841689 into main Aug 17, 2023
4 checks passed
@DOBEN DOBEN deleted the replace-json-rpc-with-grpc-in-voting branch August 17, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisgardo bisgardo bisgardo approved these changes

@abizjak abizjak abizjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOBEN @abizjak @bisgardo