-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add web3 id proofs #335
Add web3 id proofs #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When having a range proof as part of the statement, then the verifier rejects the proof.
packages/browser-wallet/src/popup/pages/VerifiableCredential/VerifiableCredentialHooks.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Web3ProofRequest/AccountStatement.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Web3ProofRequest/utils.ts
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Web3ProofRequest/Web3ProofRequest.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Web3ProofRequest/Web3ProofRequest.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Web3ProofRequest/Web3ProofRequest.tsx
Outdated
Show resolved
Hide resolved
packages/browser-wallet/src/popup/pages/Web3ProofRequest/Web3ProofRequest.tsx
Outdated
Show resolved
Hide resolved
Proof page for a request that cannot be satisfied is blank. And the title of the proof page is "Signature Request". |
If any of the statements in a request are not proofable, then it should handle it in the same way as it was just one statement that the wallet cannot satisfy. |
The proof popup has something that needs a key:
|
I made a simple view that explains to the user they can't prove the given statement, I'm not sure if we want more than that? 🤔 |
Purpose
Add web3Id proofs
Changes
Checklist
hard-to-understand areas.