Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web3 id proofs #335

Merged
merged 20 commits into from
Aug 17, 2023
Merged

Add web3 id proofs #335

merged 20 commits into from
Aug 17, 2023

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Add web3Id proofs

Changes

  • Added web3Id proof page.
  • Some adjustments to Id Proof page. (To use in web3Id proof page)

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@orhoj orhoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When having a range proof as part of the statement, then the verifier rejects the proof.

@orhoj
Copy link
Contributor

orhoj commented Aug 17, 2023

Proof page for a request that cannot be satisfied is blank. And the title of the proof page is "Signature Request".

@orhoj
Copy link
Contributor

orhoj commented Aug 17, 2023

If any of the statements in a request are not proofable, then it should handle it in the same way as it was just one statement that the wallet cannot satisfy.

@orhoj
Copy link
Contributor

orhoj commented Aug 17, 2023

The proof popup has something that needs a key:

Warning: Each child in a list should have a unique "key" prop.

@orhoj orhoj assigned shjortConcordium and unassigned orhoj Aug 17, 2023
@shjortConcordium
Copy link
Contributor Author

I made a simple view that explains to the user they can't prove the given statement, I'm not sure if we want more than that? 🤔

@orhoj orhoj assigned shjortConcordium and unassigned orhoj Aug 17, 2023
@shjortConcordium shjortConcordium merged commit 68d6a7c into feature/web3-id Aug 17, 2023
4 checks passed
@shjortConcordium shjortConcordium deleted the add-web3Id-proofs branch August 17, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants