[BRO-29] Better error reporting in the browser wallet in case TokenMe…

…tadata Updated CHANGELOG.md Removed optional params
Concordium · May 23, 2024 · 5ed6055 · 5ed6055
1 parent a108e60
commit 5ed6055
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/packages/browser-wallet/CHANGELOG.md b/packages/browser-wallet/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Added
+
+-   Additional error message. Now instead of not showing invalid tokens, they displayed in token list with corresponding error. In order to show, that we found tokens in contract, but they have error.
+
 ## 1.5.1
 
 ### Fixed

diff --git a/packages/browser-wallet/src/popup/pages/Account/Tokens/ManageTokens/ManageTokens.tsx b/packages/browser-wallet/src/popup/pages/Account/Tokens/ManageTokens/ManageTokens.tsx
@@ -69,7 +69,6 @@ export default function AddTokens() {
                 accountTokens.value[contractDetails.index.toString()]?.map((token) => ({
                     ...token,
                     balance: currentContractBalances[token.id] ?? 0n,
-                    error: '',
                 })) ?? [];
 
             setTopTokens(currentChecked);

diff --git a/packages/browser-wallet/src/shared/utils/token-helpers.ts b/packages/browser-wallet/src/shared/utils/token-helpers.ts
@@ -349,7 +349,7 @@ export async function getTokens(
     );
     const tokenData: (TokenData | undefined)[] = await Promise.all(
         ids.map(async (id, index) => {
-            const internalData: TokenData = { id, metadataLink: '', metadata: {}, balance: 0n, error: '' };
+            const internalData: TokenData = { id, metadataLink: '', metadata: {}, balance: 0n };
             let metadataUrl;
             try {
                 metadataUrl = await contract.tokenMetadata(id);