Support all relevant transaction types in trace account tool #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonkamp
commented
Sep 21, 2021
abizjak
reviewed
Sep 22, 2021
| @@ -144,15 +145,18 @@ enum AdditionalDetails { | |||
| InitContract, | |||
| #[serde(rename = "update")] | |||
| Update, | |||
| #[serde(rename = "transfer")] | |||
| #[serde(rename = "transfer", alias = "transferWithMemo")] | |||
There was a problem hiding this comment.
I know alias is convenient, but it is conceptually "wrong", so please add a separate TransferWithMemo variant.
| #[serde(rename = "encryptedAmountTransfer")] | ||
| #[serde( | ||
| rename = "encryptedAmountTransfer", | ||
| alias = "encryptedAmountTransferWithMemo" |
| EncryptedAmountTransfer(EncryptedTransfer), | ||
| #[serde(rename = "transferToEncrypted")] | ||
| TransferToEncrypted(TransferToEncrypted), | ||
| #[serde(rename = "transferToPublic")] | ||
| TransferToPublic(TransferToPublic), | ||
| #[serde(rename = "transferWithSchedule")] | ||
| #[serde(rename = "transferWithSchedule", alias = "transferWithScheduleAndMemo")] |
| of {} GTUs\n Block hash: {}\n Transaction hash: {}", | ||
| pretty_time(tx.block_time), | ||
| i, | ||
| match tx.details.additional_details {// todo can any of the transactions below affect other accounts? |
There was a problem hiding this comment.
No, they just affect the sender account.
Bargsteen
added a commit
that referenced
this pull request
Sep 13, 2023
Move `ExchangeRates` from concordium-std
Bargsteen
added a commit
that referenced
this pull request
Sep 14, 2023
Move `ExchangeRates` from concordium-std
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #77
The trace account tool should support all transactions types with an associated cost.
Changes
Made the tool robust against rejected transactions, which previously crashed it.
Added support for all update/add/remove/deploy/register transaction types.
Added support for
transferWithMemo,encryptedAmountTransferWithMemo, andtransferWithScheduleAndMemotransactions, by using their counterparts without a memo.Checklist
hard-to-understand areas.