Properly size thumbnail images with nonexistent/unavailable sources #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds some HTML and CSS to ensure that thumbnail images with bad sources are correctly sized. Resolves ComputerScienceHouse#80.
|
Is it possible to detect a bad thumbnail source in code? It'd be neat if gallery automatically regenerated the thumbnail, or reinstated the default when a broken one was loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some HTML and CSS to ensure that thumbnail images with bad sources
are correctly sized. Resolves #80.
Fix visualization (see #80 for an example of what it looked like prior):
