move and pass by reference for shared pointers

ComputationalRadiationPhysics · Jul 29, 2024 · 2867117 · 2867117
1 parent f7c108c
commit 2867117
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 11 deletions.
diff --git a/redGrapes/SchedulerDescription.hpp b/redGrapes/SchedulerDescription.hpp
@@ -29,7 +29,7 @@ namespace redGrapes
         using Key = TTag;
         using ValueType = TScheduler;
 
-        SchedulerDescription(std::shared_ptr<TScheduler> scheduler, TTag = DefaultTag{}) : scheduler{scheduler}
+        SchedulerDescription(std::shared_ptr<TScheduler> const& scheduler, TTag = DefaultTag{}) : scheduler{scheduler}
         {
         }
 

diff --git a/redGrapes/redGrapes.hpp b/redGrapes/redGrapes.hpp
@@ -190,7 +190,7 @@ namespace redGrapes
         }
 
         template<typename T>
-        auto createIOResource(std::shared_ptr<T> o) -> IOResource<T>
+        auto createIOResource(std::shared_ptr<T> const& o) -> IOResource<T>
         {
             return IOResource<T>(o);
         }

diff --git a/redGrapes/resource/fieldresource.hpp b/redGrapes/resource/fieldresource.hpp
@@ -288,7 +288,7 @@ namespace redGrapes
         static constexpr size_t dim = trait::Field<Container>::dim;
 
         FieldResource(Container* c)
-            : fieldresource::WriteGuard<Container>(TaskFreeCtx::create_resource_uid(), std::shared_ptr<Container>(c))
+            : fieldresource::WriteGuard<Container>(TaskFreeCtx::create_resource_uid(), std::make_shared<Container>(c))
         {
         }
 
@@ -304,7 +304,7 @@ namespace redGrapes
 
         template<typename U>
         FieldResource(FieldResource<U> const& res, Container* c)
-            : fieldresource::WriteGuard<Container>(res, std::shared_ptr<Container>(c))
+            : fieldresource::WriteGuard<Container>(res, std::make_shared<Container>(c))
         {
         }
 

diff --git a/redGrapes/resource/resource.hpp b/redGrapes/resource/resource.hpp
@@ -88,7 +88,7 @@ namespace redGrapes
     {
         AccessBase(boost::typeindex::type_index access_type, std::shared_ptr<ResourceBase> resource)
             : access_type(access_type)
-            , resource(resource)
+            , resource(std::move(resource))
         {
         }
 
@@ -116,7 +116,7 @@ namespace redGrapes
     template<typename AccessPolicy>
     struct Access : public AccessBase
     {
-        Access(std::shared_ptr<ResourceBase> resource, AccessPolicy policy)
+        Access(std::shared_ptr<ResourceBase> const& resource, AccessPolicy policy)
             : AccessBase(boost::typeindex::type_id<AccessPolicy>(), resource)
             , policy(policy)
         {
@@ -394,7 +394,7 @@ namespace redGrapes
     template<typename T, typename AccessPolicy>
     struct SharedResourceObject
     {
-        SharedResourceObject(ResourceId id, std::shared_ptr<T> const& obj) : res{id}, obj(obj)
+        SharedResourceObject(ResourceId id, std::shared_ptr<T> obj) : res{id}, obj(std::move(obj))
         {
         }
 
@@ -405,7 +405,7 @@ namespace redGrapes
         {
         }
 
-        SharedResourceObject(Resource<AccessPolicy> const& res, std::shared_ptr<T> const& obj) : res{res}, obj{obj}
+        SharedResourceObject(Resource<AccessPolicy> const& res, std::shared_ptr<T> obj) : res{res}, obj{std::move(obj)}
         {
         }
 

diff --git a/redGrapes/scheduler/thread_scheduler.hpp b/redGrapes/scheduler/thread_scheduler.hpp
@@ -33,7 +33,7 @@ namespace redGrapes
             }
 
             ThreadScheduler(std::shared_ptr<dispatch::thread::WorkerThread<Worker>> workerThread)
-                : m_worker_thread(workerThread)
+                : m_worker_thread(std::move(workerThread))
             {
             }
 

diff --git a/redGrapes/util/atomic_list.hpp b/redGrapes/util/atomic_list.hpp
@@ -289,7 +289,7 @@ namespace redGrapes
              * and returns the previous head to which the new_head
              * is now linked.
              */
-            auto append_item(std::shared_ptr<ItemControlBlock> new_head)
+            auto append_item(std::shared_ptr<ItemControlBlock> const& new_head)
             {
                 TRACE_EVENT("Allocator", "AtomicList::append_item()");
                 std::shared_ptr<ItemControlBlock> old_head;
@@ -306,7 +306,7 @@ namespace redGrapes
             }
 
             // append the first head item if not already exists
-            bool try_append_first_item(std::shared_ptr<ItemControlBlock> new_head)
+            bool try_append_first_item(std::shared_ptr<ItemControlBlock> const& new_head)
             {
                 TRACE_EVENT("Allocator", "AtomicList::append_first_item()");