fixes

ComputationalRadiationPhysics · Jul 31, 2024 · a3bc981 · a3bc981
1 parent 05cf228
commit a3bc981
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/...ectroniccollisonalequilibrium/__init__.py → ...ctroniccollisionalequilibrium/__init__.py b/...ectroniccollisonalequilibrium/__init__.py → ...ctroniccollisionalequilibrium/__init__.py
diff --git a/...roniccollisonalequilibrium/thomasfermi.py → ...oniccollisionalequilibrium/thomasfermi.py b/...roniccollisonalequilibrium/thomasfermi.py → ...oniccollisionalequilibrium/thomasfermi.py
diff --git a/lib/python/picongpu/picmi/interaction/ionization/fieldionization/BSI.py b/lib/python/picongpu/picmi/interaction/ionization/fieldionization/BSI.py
@@ -30,19 +30,20 @@ class BSI(FieldIonization):
 
     MODEL_NAME: str = "BSI"
 
-    BSI_extensions: list[BSIExtension]
+    BSI_extensions: tuple[BSIExtension]
     """extension to the BSI model"""
 
     def get_as_pypicongpu(self) -> pypicongpu.species.constant.ionizationmodel.IonizationModel:
         if self.BSI_extensions == []:
             return ionizationmodel.BSI(ionization_current=None_())
 
-        if self.BSI_extensions == [BSIExtension.StarkShift]:
-            return ionizationmodel.BSIStarkShifted(ionization_current=None_())
-        if self.BSI_extensions == [BSIExtension.EffectiveZ]:
-            return ionizationmodel.BSIEffectiveZ(ionization_current=None_())
-
         if len(self.BSI_extensions) > 1:
             pypicongpu.util.unsupported("more than one BSI_extension")
         else:
             pypicongpu.util.unsupported(f"unknown BSI_extension {self.BSI_extensions[0]}")
+
+        if self.BSI_extensions[0] is BSIExtension.StarkShift:
+            return ionizationmodel.BSIStarkShifted(ionization_current=None_())
+        if self.BSI_extensions[0] is BSIExtension.EffectiveZ:
+            return ionizationmodel.BSIEffectiveZ(ionization_current=None_())
+        raise ValueError("unknown BSI extension")
diff --git a/lib/python/picongpu/picmi/simulation.py b/lib/python/picongpu/picmi/simulation.py
@@ -368,7 +368,7 @@ def write_input_file(
 
     def picongpu_add_custom_user_input(self, custom_user_input: pypicongpu.customuserinput.InterfaceCustomUserInput):
         """add custom user input to previously stored input"""
-        self.picongpu_custom_user_input = (self.picongpu_custom_user_input + []) + [custom_user_input]
+        self.picongpu_custom_user_input = (self.picongpu_custom_user_input or []) + [custom_user_input]
 
     def add_interaction(self, interaction) -> None:
         pypicongpu.util.unsupported(

diff --git a/lib/python/picongpu/pypicongpu/species/constant/constant.py b/lib/python/picongpu/pypicongpu/species/constant/constant.py
@@ -51,8 +51,8 @@ def __eq__(self, other) -> bool:
             if key not in other.__dict__:
                 return False
 
-        for key, value in self.__dict__:
-            if self.value != other.__dict__[key]:
+        for key, value in self.__dict__.items():
+            if value != other.__dict__[key]:
                 return False
 
         return True