Update Media Element to use Media3 #2076

ne0rrmatrix · 2024-07-31T09:20:45Z

Description of Change

Port Media Element to use Media 3 Binding from Xamarin AndroidX team. This will allow us to stop using deprecated methods and classes and move forward with adding new features to this media player.

Linked Issues

PR Checklist

Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard
Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

This is currently not ready for review or testing yet. It should be ready in a day or two. ATM it works fine in Android 33/34 but I have to test and then port the new controls to older API's over the next few days.

Also camera nuget needs to tested and verified the package updates I added did not break anything. Had to be done for Media Element to compile.

Updated `CommunityToolkit.Maui.MediaElement.csproj` to replace `Xam.Plugins.Android.ExoPlayer` with `Xamarin.AndroidX.Media3` packages. In `MediaControlsService.android.cs`, updated drawable resources for media control actions to new icons. Replaced `StyledPlayerView` with `PlayerView` in `MauiMediaElement.android.cs`. Refactored `MediaManager.android.cs` to use `AndroidX.Media3` classes and interfaces, updating method signatures and interface implementations. Updated `MediaManager.shared.cs` to use `AndroidX.Media3.ExoPlayer.IExoPlayer` for Android. Aligned methods and properties with the new Media3 API, including playback state handling, error handling, and media session management. Refactored `OnPlaybackStateChanged` and `OnPlayerStateChanged` methods to handle new playback state values. Modified `InitializeMediaSession` to comment out `MediaSessionConnector` and adjust media session setup. Ensured compatibility with the new Media3 library across various methods.

Updated `CommunityToolkit.Maui.Camera.csproj` and `CommunityToolkit.Maui.MediaElement.csproj` to use newer versions of several Xamarin.AndroidX packages and added new package references. Refactored `MediaManager.android.cs`: - Removed unused imports and added new ones. - Replaced `MediaControllerCompat` and `MediaSessionCompat` with `MediaSession`. - Updated `OnPlaybackStateChanged` to use `PlaybackStateCompat` constants. - Removed `BroadcastUpdate` method and related calls. - Introduced `SetPlayerData` method for setting media metadata. - Removed `InitializeMediaSession` method and related calls. - Updated `StartService` to use the new `MediaSession`. - Removed `UIUpdateReceiver` class and related calls. - Updated method signatures to use new types from updated AndroidX libraries.

Removed AudioManager and related methods from MediaControlsService. Replaced Trace.WriteLine with Trace.TraceError for error logging. Removed OnSetupAudioServices method and its calls. Modified InitializeNotification to remove SetShowActionsInCompactView. Refactored OnSetContent and OnSetIntents methods. Added UIUpdateReceiver class to handle updates from MediaControlsService. Registered and unregistered UIUpdateReceiver in MediaManager. Added BroadcastUpdate methods for play and pause actions. Updated SetPlayerData to return MediaItem.Builder. Aligned method signatures with new MediaItem.Builder approach. Handled ACTION_PLAY, ACTION_PAUSE, ACTION_FASTFORWARD, and ACTION_REWIND in UIUpdateReceiver. Updated method names and parameters to match AndroidX Media3 conventions. Removed redundant or obsolete code and comments.

Updated `CommunityToolkit.Maui.Camera.csproj` and `CommunityToolkit.Maui.MediaElement.csproj`: - Removed `Xamarin.AndroidX.Lifecycle.LiveData`. - Downgraded several `Xamarin.AndroidX.Lifecycle` packages from `2.8.4` to `2.8.3.1`. - Downgraded `Xamarin.AndroidX.Activity.Ktx` from `1.9.1` to `1.9.0.4`. - Corrected `Xamarin.AndroidX.Media3.Ui` to `Xamarin.AndroidX.Media3.UI`. Enhanced `MediaManager.android.cs`: - Added `mediaSession` field to `MediaManager` class. - Updated `SetPlayerData` to set media ID using `mediaItem.SetMediaId(url)`. - Updated method signatures to use fully qualified names for `global::AndroidX.Media3.Common` types.

Refactored MediaManager.android.cs for improved readability and maintainability. Updated package references in CommunityToolkit.Maui.MediaElement.csproj, including the removal of Xamarin.AndroidX.Media3.Transformer and addition of new ExoPlayer packages. Enhanced method implementations and ensured compatibility with updated packages.

…ing.

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs

Refactored `PlatformPause`, `PlatformSeek`, `PlatformStop`, and `PlatformUpdateSource` methods to streamline code and reduce potential issues: - Removed TODO comment in `PlatformPause`. - Simplified `PlatformSeek` by removing listener management and async handling. - Changed `PlatformStop` to a synchronous method, ensuring proper player stop without async seek. - Updated `PlatformUpdateSource` to set media items directly without modifying the listener.

Updated .NET to `net8.0` and Maui to `8.0.70` in `Directory.Build.props`. Removed old `Xamarin.AndroidX` packages and added `Xamarin.AndroidX.Collection.Jvm` and `Xamarin.AndroidX.Activity.Ktx` in `CommunityToolkit.Maui.MediaElement.csproj`. Introduced constants for playback states (`sTATE_IDLE`, `sTATE_BUFFERING`, `sTATE_READY`, `sTATE_ENDED`) and replaced `PlaybackStateCompat.StatePlaying` with `sTATE_READY` in `MediaManager.android.cs`. Added `Player.SetHandleAudioBecomingNoisy(true)` for handling audio interruptions and a `UIUpdateReceiver` for UI updates based on player state changes. Improved error handling in `PlatformSeek` method to avoid exceptions and ensure execution on the calling thread. Initialized `MediaItem.Builder` in `SetPlayerData` method. Updated `PlatformUpdateAspect` and `PlatformUpdateShouldLoopPlayback` methods to set properties based on `MediaElement` attributes.

* Modified `PlatformStop` to reset media position to start (0) and explicitly set `MediaElement.Position` to `TimeSpan.Zero`. * Added `MediaSession` release and disposal.

…at is compatible.

…Media3

Removed `System.Runtime.InteropServices` and `Microsoft.Win32.SafeHandles` using directives from `MediaControlsService.android.cs` as they are no longer referenced in the code.

…tion back if it is cancelled when playback rersumes. Moved notification into on create.

Revert changes to Camera

ne0rrmatrix · 2024-10-01T08:24:19Z

This PR is ready for review. The requested changes including a fix for the issue with foreground service startup and crash on null Intent has been fixed. The changes made to other packages have been removed and are no longer needed after latest update last week. The media 3 packages are now aligned with current version of media 3 and are stable.

KeithBoynton · 2024-10-16T08:34:54Z

Keen to see this reviewed and merged so I can get along with contributing some Android playlist support

brminnick · 2024-10-23T19:19:32Z

src/CommunityToolkit.Maui.Camera/CommunityToolkit.Maui.Camera.csproj

-
-    <!-- Xamarin.AndroidX.Camera 1.3.1.1 depends on Xamarin.AndroidX.Lifecycle.LiveData 2.7.0.1:
-    https://www.nuget.org/packages/Xamarin.AndroidX.Camera.Core/#dependencies-body-tab 
-    However, Dotnet MAUI still implicitly references Xamarin.AndroidX.Lifecycle.LiveData 2.6.1.3:
-    https://github.com/dotnet/maui/blob/main/eng/AndroidX.targets
-    This causes build error "Detected package downgrade":
-    https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu1605
-    Workaround: add a package reference to the higher version of the package. Possibly can be removed when MAUI bumps the implicit reference version.
-    -->
-    <PackageReference Include="Xamarin.AndroidX.Lifecycle.LiveData" Version="2.7.0.1" />
-
-    <!--Adding the above package reference requires Workaround for https://github.com/xamarin/AndroidX/issues/800#issuecomment-1774639627 -->
-    <!-- Tracking issue https://github.com/xamarin/AndroidX/issues/764 -->
-    <PackageReference Include="Xamarin.AndroidX.Collection" Version="1.4.0.1" />
-    <PackageReference Include="Xamarin.AndroidX.Collection.Ktx" Version="1.4.0.1" />


Let's move this to a separate PR since it not related to CommunityToolkit.Maui.MediaElement

I will try reverting the changes. It was only modified so that transient dependancies did not clash

I just looked at the code and was unable to find the referenced code. It has been removed. Not sure when. Can you try updating your local source.

KeithBoynton · 2024-10-31T20:37:50Z

Hi @brminnick any joy with progressing the review of this? Getting this merged would really help me with some playlist related work I need to do on the Media Element. It looks like James responded to your comments

brminnick · 2024-10-31T20:40:13Z

@KeithBoynton My current focus is preparing for .NET 9

KeithBoynton · 2024-10-31T21:12:24Z

@brminnick If there's not much left outstanding on the review, it really would help unblock so we can work on the Media Element while you're focussing on .NET 9

pictos

Just a small comment. I believe this is really close to be merged

src/CommunityToolkit.Maui.MediaElement/Services/BoundServiceBinder.android.cs

pictos · 2024-10-31T22:50:00Z

@ne0rrmatrix, is this like ready to go? IF so I can give it try on my end. But I just have an emulator for now, I believe it will work

ne0rrmatrix · 2024-10-31T22:59:52Z

@ne0rrmatrix, is this like ready to go? IF so I can give it try on my end. But I just have an emulator for now, I believe it will work

Gimme 30 min. I am just finishing the recommended changes you requested. I found another case of private set. I am updating and testing those changes. Once that is done it should be good to go.

ne0rrmatrix · 2024-10-31T23:05:42Z

Changes done! Ready for you to test in emulator @pictos

ne0rrmatrix added 2 commits July 30, 2024 17:07

ne0rrmatrix mentioned this pull request Jul 31, 2024

[Proposal] Port Android MediaElement from Exoplayer to Media3 #1511

Open

8 tasks

brminnick added the needs discussion Discuss it on the next Monthly standup label Jul 31, 2024

ne0rrmatrix added 6 commits July 31, 2024 18:39

Merge branch 'CommunityToolkit:main' into Media3

643f7f4

Add TODO and note with request for help solving async issue with seek…

86fbb29

…ing.

Merge branch 'main' into Media3

81bf905

ne0rrmatrix commented Aug 2, 2024

View reviewed changes

src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs Show resolved Hide resolved

ne0rrmatrix self-assigned this Aug 3, 2024

ne0rrmatrix added the 📽️ MediaElement Issue/PR that has to do with MediaElement label Aug 3, 2024

ne0rrmatrix mentioned this pull request Aug 4, 2024

Cannot replace a media item or seek in Exoplayer when adding a listener xamarin/AndroidX#929

Closed

ne0rrmatrix and others added 11 commits August 3, 2024 19:11

Merge branch 'main' into Media3

02a7520

Refactor player control and resource disposal

7139e1a

* Modified `PlatformStop` to reset media position to start (0) and explicitly set `MediaElement.Position` to `TimeSpan.Zero`. * Added `MediaSession` release and disposal.

Merge branch 'main' into Media3

9992bcf

Merge branch 'main' into Media3

5743aff

Merge branch 'main' into Media3

5b39d8a

Merge branch 'main' into Media3

c967d6b

Update changes from media2 for playerView poster to media3 version th…

56ce4ba

…at is compatible.

Merge branch 'CommunityToolkit:main' into Media3

e306d86

Add SafeFireAndForget

9d2aca9

Merge branch 'main' into Media3

391422e

brminnick added the blocked label Aug 19, 2024

ne0rrmatrix added 3 commits August 19, 2024 15:56

Merge branch 'CommunityToolkit:main' into Media3

a9803df

Update nuget version and apply fixes for changes

25d1a83

Merge branch 'Media3' of https://github.com/ne0rrmatrix/MauiOld into …

c091d74

…Media3

ne0rrmatrix requested a review from a team September 24, 2024 15:22

ne0rrmatrix mentioned this pull request Sep 24, 2024

[BUG] MediaElement Android crashes when OnFullscreenButtonClick #2044

Open

2 tasks

ne0rrmatrix added 4 commits September 24, 2024 09:12

Remove unused using directives in MediaControlsService

3b0eec4

Removed `System.Runtime.InteropServices` and `Microsoft.Win32.SafeHandles` using directives from `MediaControlsService.android.cs` as they are no longer referenced in the code.

Updated to address null intent. Added rebind override to add notifica…

005eb79

…tion back if it is cancelled when playback rersumes. Moved notification into on create.

Update nugets for media 3

6b8c952

Revert changes to Camera

Merge branch 'main' into Media3

ab9cb9d

ne0rrmatrix mentioned this pull request Sep 30, 2024

Add Subtitle Support for MediaElement #1918

Draft

6 tasks

Merge branch 'main' into Media3

1d4dbf0

ne0rrmatrix added 2 commits October 4, 2024 11:38

Merge branch 'main' into Media3

ad2edac

Merge branch 'main' into Media3

31417c6

ne0rrmatrix removed the blocked label Oct 15, 2024

Merge branch 'main' into Media3

2b430f2

ne0rrmatrix added 2 commits October 16, 2024 01:40

Merge branch 'main' into Media3

46bd46b

Merge branch 'main' into Media3

1f2a35c

brminnick reviewed Oct 23, 2024

View reviewed changes

Merge branch 'main' into Media3

b2fbdad

pictos reviewed Oct 31, 2024

View reviewed changes

src/CommunityToolkit.Maui.MediaElement/Services/BoundServiceBinder.android.cs Outdated Show resolved Hide resolved

This comment was marked as spam.

Sign in to view

Make Bound Service immutable

ceae648

Update bound service connection to not use private set.

0d0e241

ne0rrmatrix mentioned this pull request Oct 31, 2024

[BUG] .NET MAUI 8.0 Android 14: AndroidX.LocalBroadcastManager.Content.LocalBroadcastManager not supported on Android 13 and above. #2293

Open

2 tasks

Merge branch 'main' into Media3

2825a67

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Media Element to use Media3 #2076

Update Media Element to use Media3 #2076

ne0rrmatrix commented Jul 31, 2024 •

edited

Loading

ne0rrmatrix commented Oct 1, 2024

KeithBoynton commented Oct 16, 2024

brminnick Oct 23, 2024

ne0rrmatrix Oct 24, 2024

ne0rrmatrix Oct 24, 2024

KeithBoynton commented Oct 31, 2024

brminnick commented Oct 31, 2024

KeithBoynton commented Oct 31, 2024

pictos left a comment

This comment was marked as spam.

pictos commented Oct 31, 2024

ne0rrmatrix commented Oct 31, 2024

ne0rrmatrix commented Oct 31, 2024

Update Media Element to use Media3 #2076

Are you sure you want to change the base?

Update Media Element to use Media3 #2076

Conversation

ne0rrmatrix commented Jul 31, 2024 • edited Loading

Description of Change

Linked Issues

PR Checklist

Additional information

ne0rrmatrix commented Oct 1, 2024

KeithBoynton commented Oct 16, 2024

brminnick Oct 23, 2024

Choose a reason for hiding this comment

ne0rrmatrix Oct 24, 2024

Choose a reason for hiding this comment

ne0rrmatrix Oct 24, 2024

Choose a reason for hiding this comment

KeithBoynton commented Oct 31, 2024

brminnick commented Oct 31, 2024

KeithBoynton commented Oct 31, 2024

pictos left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

pictos commented Oct 31, 2024

ne0rrmatrix commented Oct 31, 2024

ne0rrmatrix commented Oct 31, 2024

ne0rrmatrix commented Jul 31, 2024 •

edited

Loading