Chore: Minor fixes & improvements #2232
Open
+93
−198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
LCOV of commit
|
Assigning to `el_composition.data` would cause the sample to be considered as `isEdited`.
Before this change, we would `this.state.sortColumn = ...` during render in order to get the latest value from UserStore. Now we properly listen (and unlisten) for store changes and update the state using `this.setState`. With this change we also set the initial UIStore state when the component mounts and not only when the store state changes.
The ManagingActions component handles syncing genericEls with UserStore itself. No need to pass that information in as prop.
We used to copy the state to determine whether the selection had changed or not. However, we can simply calculate that information from the UIStore state without the local state.
This used to trigger `UIState.handleSelectSyncCollection` which forwarded to `UIStore.handleSelectCollection`. Removing in favour of less indirection.
Before this change, we would always reset the currentTab to 0 and not use the data stored in the UserStore. This was fine when we never unmounted/mounted the ElementList component but leads to the undesired effect of not respecting the user's selected tab when we unmount/mount the component.
This was used to force a re-render when changing to full screen. It does not seem to be necessary anymore.
Also fix collection type. JS Array has no `size` property.
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor issues that came up while implementing the new navigation structure designed by shapefield. Extracting those issues into a PR so they can be reviewed separately without the navigation restructuring.