feat: Ket2 surface chemistry #2230
Draft
+1,157
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/chemotion_ELN into ketcher-surface-chemistry
…t/chemotion_ELN into ketcher-surface-chemistry
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -20,6 +20,10 @@ def scrub_svg(fragment, encoding: nil) | |||
| def base_scrub_ml(fragment, type: :xml, encoding: nil) | |||
| result = encoding ? fragment.encode(encoding) : fragment | |||
|
|
|||
| # Allow the <image> tag and all its attributes | |||
| scrubber = Loofah::Scrubber.new do |node| | |||
| node['src'] = node['src'] if node.name == 'image' | |||
There was a problem hiding this comment.
Lint/SelfAssignment: Self-assignment detected.
| when /chemdraw/i | ||
| Chemotion::ChemdrawSvgProcessor.new(svg) | ||
| when /ketcher/i | ||
| Ketcherails::SVGProcessor.new(svg) | ||
| else | ||
| Chemotion::OpenBabelSvgProcessor.new(svg) | ||
| end | ||
|
|
||
| editor === 'ketcher2' && is_centered = true |
There was a problem hiding this comment.
Style/CaseEquality: Avoid the use of the case equality operator ===.
| when /chemdraw/i | ||
| Chemotion::ChemdrawSvgProcessor.new(svg) | ||
| when /ketcher/i | ||
| Ketcherails::SVGProcessor.new(svg) | ||
| else | ||
| Chemotion::OpenBabelSvgProcessor.new(svg) | ||
| end | ||
|
|
||
| editor === 'ketcher2' && is_centered = true |
There was a problem hiding this comment.
Lint/ShadowedArgument: Argument is_centered was shadowed by a local variable before it was used.
haditariq
force-pushed
the
ketcher-surface-chemistry
branch
3 times, most recently
from
ada46b4
to
68e2891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resolves: Issue#166.
Demo:
1- Basic Usage image template
k2SC.image.template.usage.mp4
2- Molfile compatibility with Ketcherrails and ketcher2
k2SC.-.Rails.and.ketcher2.compatibility.mp4
3- Modify image templates with new user templates
k2SC.-.use.template.with.image.templates.1.mp4
4- Redo and Undo features
redo.and.undo.feature.1.mp4
5- Erase Del will not work on image templates else should act same for other atoms/mols
erase.del.feature.k2sc.1.mp4
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release