Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bootstrap: Fix collection sharing modal #2217

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update bootstrap: Fix collection sharing modal #2217

merged 2 commits into from
Oct 15, 2024

Conversation

maiwald
Copy link
Collaborator

@maiwald maiwald commented Oct 15, 2024

No description provided.

@maiwald
Use conditional rendering instead of display: none
0ba7a54
@maiwald
Fix saving sharing permissions when editing
2873670 
When editing existing sharing permissions we pass the `selectUsers`
prop. The previous condition for disabling the submit button did not
take this into account.
@github-actions GitHub Actions
Copy link

LCOV of commit 2873670 during Continuous Integration #4007

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

beque
beque approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@beque beque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maiwald maiwald marked this pull request as ready for review October 15, 2024 14:02
@maiwald maiwald merged commit 0a87479 into update-bootstrap-ui-library Oct 15, 2024
3 checks passed
@maiwald maiwald deleted the update-bootstrap-fix-collection-sharing-modal branch October 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beque beque beque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiwald @beque