Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap css cleanup #2198

Merged

Conversation

JoachimTillessen
Copy link
Collaborator

  • rather 1-story 1-commit than sub-atomic commits

  • commit title is meaningful => git history search

  • commit description is helpful => helps the reviewer to understand the changes

  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured

  • added code is linted

  • tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited

  • in case the changes are visible to the end-user,  video or screenshots should be added to the PR => helps with user testing

  • testing coverage improvement is improved.

  • CHANGELOG :  add a bullet point on top (optional: reference to github issue/PR )

  • parallele PR for documentation  on docusaurus  if the feature/fix is tagged for a release

Copy link

github-actions bot commented Oct 7, 2024

LCOV of commit 7ff24f5 during Continuous Integration #3943

Summary coverage rate:
  lines......: 65.5% (14012 of 21402 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link

github-actions bot commented Oct 7, 2024

LCOV of commit ad6bbac during Continuous Integration #3945

Summary coverage rate:
  lines......: 65.5% (14012 of 21402 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link
Collaborator

@maiwald maiwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selects are looking good! 👍

@JoachimTillessen JoachimTillessen merged commit 45c14e1 into update-bootstrap-ui-library Oct 7, 2024
3 checks passed
@JoachimTillessen JoachimTillessen deleted the update-bootstrap-css-cleanup branch October 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants