Bootstrap upgrade bugfixes 2 #2189

ashwiniHerle · 2024-09-30T09:01:05Z

Minor styling fixes related to bootstrap upgrade.
Made analyses look similar throughout samples, reactions and researchplans, wellplates and cellLines
Fix for issue where contextActions buttons vertically expanded in smaller screens
Show notification message numbers on NoticeButton

beque

Just some small fixes.

I have seen that the Analyses Header of CellLine and Wellplate still look different

beque · 2024-09-30T13:39:30Z

app/packs/src/apps/mydb/elements/details/reactions/ReactionDetails.js

-      <div className="tabs-container--with-borders">
+      <div
+        // className="tabs-container--with-borders"
+      >


Should this class be removed?

beque · 2024-09-30T13:41:09Z

app/packs/src/apps/mydb/elements/details/reactions/ReactionDetails.js

              <ReactionDetailsContainers
                reaction={reaction}
                readOnly={!permitOn(reaction)}
                handleSubmit={this.handleSubmit}
                handleReactionChange={this.handleReactionChange}
              />
-            </ListGroupItem>
+            {/* </ListGroupItem> */}
          </Tab>


Can the ListGroupItem be removed?

beque · 2024-09-30T13:43:27Z

app/packs/src/apps/mydb/elements/details/reactions/analysesTab/ReactionDetailsContainers.js

@@ -352,56 +351,72 @@ export default class ReactionDetailsContainers extends Component {
      ));

      if (analyses_container.length === 1 && analyses_container[0].children.length > 0) {
+
+


Minimum one empty line too much

beque · 2024-09-30T13:57:51Z

app/packs/src/apps/mydb/elements/details/reactions/analysesTab/ReactionDetailsContainers.js

Button in Analyses Header have no gap

beque · 2024-09-30T14:07:32Z

...ks/src/apps/mydb/elements/details/researchPlans/analysesTab/ResearchPlanDetailsContainers.js

              {analysesContainer[0].children.map((container, key) => {
                if (container.is_deleted) {
                  return (
                    <Accordion.Item
                      eventKey={key}
                      key={`research_plan_container_deleted_${container.id}`}
+                      className="border rounded overflow-hidden"


The border is too big. Maybe border rounded is not necessary here

beque · 2024-09-30T14:08:49Z

...ks/src/apps/mydb/elements/details/researchPlans/analysesTab/ResearchPlanDetailsContainers.js

Buttons in Analyses Header have no gap

ashwiniHerle · 2024-10-01T16:07:59Z

Have made necessary changes based on feedback and also fixed few undefined errors in cellLines.

beque

Just 2 analyses components with double border and one question.
When you fixed this you can merge this PR.

The navigation buttons looking good on laptop and big screen

beque · 2024-10-02T15:12:05Z

app/packs/src/apps/mydb/elements/details/cellLines/analysesTab/EditModeRow.js

-      />
-    </Accordion.Body>
-  </Accordion.Item>
+  <Card eventKey={container.id}>


There is a double border around the analyses header.
If you add border-0 at <Card> it should look good
Other analyses have the classes border-0 rounded-0

beque · 2024-10-02T15:43:21Z

...ks/src/apps/mydb/elements/details/researchPlans/analysesTab/ResearchPlanDetailsContainers.js

                return (
-                  <Accordion.Item
+                  <Card
                    eventKey={key}
                    key={`research_plan_container_${container.id}`}
                  >


Adding class border-0 removes double border
Other analyses have the classes border-0 rounded-0

beque · 2024-10-02T16:04:40Z

app/packs/src/components/sampleTaskInbox/SampleTaskNavigationElement.js

@@ -3,16 +3,16 @@ import { observer } from 'mobx-react';
 import { Button, Badge } from 'react-bootstrap';
 import { StoreContext } from 'src/stores/mobx/RootStore';

-const SampleTaskNavigationElement = ({}) => {
+function SampleTaskNavigationElement() {


Why have you changed this?
const SampleTaskNavigationElement = ({}) => is correct

There were linting errors. I'll undo it

github-actions · 2024-10-08T08:23:11Z

LCOV of commit `d6bdd2c` during Continuous Integration #3952

Summary coverage rate:
  lines......: 65.5% (14012 of 21402 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

ashwiniHerle requested a review from JoachimTillessen September 30, 2024 09:39

beque reviewed Sep 30, 2024

View reviewed changes

ashwiniHerle force-pushed the bootstrap-upgrade-bugfixes-2 branch from 468f005 to ae9d55d Compare October 2, 2024 13:54

beque reviewed Oct 2, 2024

View reviewed changes

ashwiniHerle added 19 commits October 7, 2024 10:26

use bootstrap classes for wellplates dropzone

d538d5f

fix metadata icon display issue

e7636d7

remove redundant borders in research plans

7ef8f07

wip: improvise analyses code

39fe4cf

use card to display analyses

e11d935

remove external css class in analyses

5dbdc2b

format code

c4f8e62

change the order of css imports and reapply css classes

3e7669e

use dnd-zone class for drag and drop styling

3dd6a99

wip: extend analyses changes to wellplates

1377e37

change the order of sample.scss to get css classes working

37a9f9d

fix undefined errors by converting to arrow functions

dd99f43

code cleanup

dc5fd3c

extend analyses changes to wellplates and cellLines

524382d

remove inline styles from NoticeButton

6c8338a

code cleanup

f0fc20d

format AutoCompleteInput and spacing changes

1154a47

fix for contextActions display issue on smaller screens

06787c4

remove double borders in analyses and undo changes

d53e2b5

ashwiniHerle force-pushed the bootstrap-upgrade-bugfixes-2 branch from 3629693 to d53e2b5 Compare October 7, 2024 10:26

ashwiniHerle added 2 commits October 8, 2024 07:59

fix analyses tests based on updated code

03c3136

code cleanup

d6bdd2c

ashwiniHerle merged commit 69ed236 into update-bootstrap-ui-library Oct 8, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bootstrap upgrade bugfixes 2 #2189

Bootstrap upgrade bugfixes 2 #2189

ashwiniHerle commented Sep 30, 2024 •

edited

Loading

beque left a comment

beque Sep 30, 2024

beque Sep 30, 2024

beque Sep 30, 2024

beque Sep 30, 2024

beque Sep 30, 2024

beque Sep 30, 2024

ashwiniHerle commented Oct 1, 2024

beque left a comment

beque Oct 2, 2024

beque Oct 2, 2024

beque Oct 2, 2024

ashwiniHerle Oct 2, 2024

github-actions bot commented Oct 8, 2024

		@@ -352,56 +351,72 @@ export default class ReactionDetailsContainers extends Component {
		));

		if (analyses_container.length === 1 && analyses_container[0].children.length > 0) {

Bootstrap upgrade bugfixes 2 #2189

Bootstrap upgrade bugfixes 2 #2189

Conversation

ashwiniHerle commented Sep 30, 2024 • edited Loading

beque left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashwiniHerle commented Oct 1, 2024

beque left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 8, 2024

LCOV of commit d6bdd2c during Continuous Integration #3952

ashwiniHerle commented Sep 30, 2024 •

edited

Loading

LCOV of commit `d6bdd2c` during Continuous Integration #3952