conversion rate in reaction scheme #2159
Open
+295
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -614,6 +614,7 @@ def build_sql_reaction_sample(columns, c_id, ids, checkedAll = false) | |||
| # reactions_sample: | |||
| equivalent: ['r_s.equivalent', '"r eq"', 10], | |||
| reference: ['r_s.reference', '"r ref"', 10], | |||
| conversion_rate: ['r_s.conversion_rate', '"r conversion rate"', 10], | |||
There was a problem hiding this comment.
Metrics/ModuleLength: Module has too many lines. [611/100]
| @@ -113,7 +113,7 @@ def create_new_sample(sample, fixed_label) | |||
| :type, :molecule, :collection_id, :short_label, :waste, :show_label, :coefficient, :user_labels, | |||
| :boiling_point_lowerbound, :boiling_point_upperbound, | |||
| :melting_point_lowerbound, :melting_point_upperbound, :segments, :gas_type, | |||
| :gas_phase_data | |||
| :gas_phase_data, :conversion_rate | |||
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for create_new_sample is too high. [<9, 35, 5> 36.48/25]
| @@ -215,6 +215,7 @@ def associate_sample_with_reaction(sample, modified_sample, material_group) | |||
| type: reactions_sample_klass, | |||
| gas_type: sample.gas_type, | |||
| gas_phase_data: sample.gas_phase_data, | |||
| conversion_rate: sample.conversion_rate, | |||
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for associate_sample_with_reaction is too high. [<2, 26, 2> 26.15/25]
| @@ -215,6 +215,7 @@ def associate_sample_with_reaction(sample, modified_sample, material_group) | |||
| type: reactions_sample_klass, | |||
| gas_type: sample.gas_type, | |||
| gas_phase_data: sample.gas_phase_data, | |||
| conversion_rate: sample.conversion_rate, | |||
There was a problem hiding this comment.
Metrics/MethodLength: Method has too many lines. [32/30]
| @@ -82,6 +82,9 @@ class Import::ImportJson | |||
| # 'r_uuid' => nil, | |||
| # 'r_reference' => nil, | |||
| # 'r_equivalent' => nil, | |||
| # 'r_gas_type' => nil, | |||
There was a problem hiding this comment.
Metrics/ClassLength: Class has too many lines. [285/200]
| @@ -374,7 +377,9 @@ def add_to_reaction(klass, el, new_el) | |||
| if new_data && new_data[r_uuid] && new_data[r_uuid]['id'] | |||
| @log['samples'][el_uuid][klass.name] = klass.create( | |||
| sample_id: new_el.id, reaction_id: new_data[r_uuid]['id'], | |||
| reference: ref, equivalent: eq, position: el['r_position'] | |||
| reference: ref, equivalent: eq, position: el['r_position'], | |||
There was a problem hiding this comment.
Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
| @@ -361,7 +361,7 @@ def material_hash(material, is_product=false) | |||
| mol: valid_digit(mmol, digit), | |||
| mmol_unit: mmol_unit, | |||
| equiv: valid_digit(s.equivalent, digit), | |||
| molecule_name_hash: s[:molecule_name_hash] | |||
| molecule_name_hash: s[:molecule_name_hash], | |||
There was a problem hiding this comment.
Metrics/ClassLength: Class has too many lines. [627/200]
| @@ -361,7 +361,7 @@ def material_hash(material, is_product=false) | |||
| mol: valid_digit(mmol, digit), | |||
| mmol_unit: mmol_unit, | |||
| equiv: valid_digit(s.equivalent, digit), | |||
| molecule_name_hash: s[:molecule_name_hash] | |||
| molecule_name_hash: s[:molecule_name_hash], | |||
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for material_hash is too high. [<10, 51, 7> 52.44/25]
| @@ -361,7 +361,7 @@ def material_hash(material, is_product=false) | |||
| mol: valid_digit(mmol, digit), | |||
| mmol_unit: mmol_unit, | |||
| equiv: valid_digit(s.equivalent, digit), | |||
| molecule_name_hash: s[:molecule_name_hash] | |||
| molecule_name_hash: s[:molecule_name_hash], | |||
There was a problem hiding this comment.
Metrics/CyclomaticComplexity: Cyclomatic complexity for material_hash is too high. [8/7]
| @@ -361,7 +361,7 @@ def material_hash(material, is_product=false) | |||
| mol: valid_digit(mmol, digit), | |||
| mmol_unit: mmol_unit, | |||
| equiv: valid_digit(s.equivalent, digit), | |||
| molecule_name_hash: s[:molecule_name_hash] | |||
| molecule_name_hash: s[:molecule_name_hash], | |||
There was a problem hiding this comment.
Metrics/MethodLength: Method has too many lines. [32/30]
LCOV of commit
|
LCOV of commit
|
Chemotion.dev.8.webm |
Chemotion.dev.9.webm |
LCOV of commit
|
TasnimMehzabin
approved these changes
Oct 8, 2024
adambasha0
force-pushed
the
reaction-conversion-rate
branch
from
729eeeb
to
3f82f54
Compare
LCOV of commit
|
adambasha0
force-pushed
the
reaction-conversion-rate
branch
from
d455039
to
1b279f8
Compare
adambasha0
force-pushed
the
reaction-conversion-rate
branch
from
1b279f8
to
a11b53b
Compare
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release