Sign the executable and the installer on Windows

Close #8
ColinDuquesnoy · Aug 1, 2015 · 84af1a0 · 84af1a0
1 parent fef2887
commit 84af1a0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/package/windows/setup.iss.in b/package/windows/setup.iss.in
@@ -29,6 +29,7 @@ SetupIconFile=src\app\icons\mellowplayer.ico
 Compression=lzma
 SolidCompression=yes
 ChangesAssociations=yes
+SignTool=digicert
 
 [Languages]
 Name: "english"; MessagesFile: "compiler:Default.isl"
@@ -48,4 +49,4 @@ Name: "{commondesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks:
 Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: quicklaunchicon
 
 [Run]
-Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
+Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
diff --git a/tools/devhelper.py b/tools/devhelper.py
@@ -147,9 +147,9 @@ def make_dist_dir():
 
     files = [
         exe,
-        os.path.join(qt_bin_dir, 'icudt53.dll'),
-        os.path.join(qt_bin_dir, 'icuin53.dll'),
-        os.path.join(qt_bin_dir, 'icuuc53.dll'),
+        os.path.join(qt_bin_dir, 'icudt54.dll'),
+        os.path.join(qt_bin_dir, 'icuin54.dll'),
+        os.path.join(qt_bin_dir, 'icuuc54.dll'),
         os.path.join(qt_bin_dir, 'Qt5Core.dll'),
         os.path.join(qt_bin_dir, 'Qt5Gui.dll'),
         os.path.join(qt_bin_dir, 'Qt5Multimedia.dll'),
@@ -205,6 +205,9 @@ def make_dist_dir():
             data.append(l)
         dst.writelines(data)
 
+    print('signing mellowplayer executable')
+    os.system('c:\DigiCertUtil.exe sign /noInput %s' % os.path.join(dist, 'MellowPlayer.exe'))
+
     os.environ['PATH'] += ';C:\Program Files (x86)\Inno Setup 5'
     os.system('iscc %s' % os.path.join(os.getcwd(), 'setup.iss'))