Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negotiate authentication #33

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
003ff92
Initial commit of NTLM support
May 8, 2021
c7fdedf
Make AuthenticationType private, add changes to changelog
May 9, 2021
e5fcb52
Fix sonarQube warnings about https and fixup import naming
May 24, 2021
f30553d
First pass at Negotiate implementation
Aug 25, 2021
fc372b7
Update documentation and package export
Aug 25, 2021
4f4c2d0
Skip test_ntlm if extra is not present
Aug 25, 2021
95021ad
Add extra to travis install script and add missing changelog...
Aug 25, 2021
a34f030
Remove extra comma in extras
Aug 25, 2021
e06d98b
Merge branch 'develop' into features/ntlm
da1910 Aug 25, 2021
89043ea
Add additional tests to close some gaps in coverage
Aug 25, 2021
cde7861
Merge remote-tracking branch 'fork/features/ntlm' into features/ntlm
Aug 25, 2021
752f73a
Patch correct file
Aug 25, 2021
3eae2ae
Extract Negotiate to separate file
Aug 25, 2021
0af9cd5
Patch correct method on linux
Aug 25, 2021
e39b884
Reformat test_ntlm and fixup sonarqube issue
Aug 25, 2021
de51c34
Add tests and fix cookie handling issue
Aug 25, 2021
7360db9
Extract methods and constants from test_ntlm.py
Aug 25, 2021
dd89aa6
Add MockDefinition object to test_ntlm.py, remove some more duplication
Aug 25, 2021
569cd80
Add test for missing extra
Aug 26, 2021
b2183c0
Remove test that does not work...
Aug 26, 2021
444c1ac
Remove test that does not work...
Aug 26, 2021
f167fdb
Merge remote-tracking branch 'fork/features/ntlm' into features/ntlm
Aug 26, 2021
3495ae5
Remove test that does not work...
Aug 26, 2021
555d91b
Squash warnings about pytest_mock as a context manager
Aug 26, 2021
85642f6
Merge branch 'develop' of https://github.com/colin-b/httpx_auth into …
da1910 Oct 7, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- `httpx_auth.authentication` contains a new `Negotiate` class that supports Kerberos and NTLM authentication without
support for channel binding tokens
- Added extra `windows_auth` to enable support for Negotiate and NTLM authentication

### Changed
- Optionally requires [`pyspnego[kerberos]`](https://github.com/jborean93/pyspnego)==0.1.6
- Requires [`pytest`](https://docs.pytest.org/en/latest)==6.2.\* for testing
- Requires [`pytest-mock`](https://github.com/pytest-dev/pytest-mock)==3.6.\* for testing

## [0.15.0] - 2022-06-01
### Changed
Expand Down
45 changes: 45 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,51 @@ with httpx.Client() as client:
| `username` | User name. | Mandatory | |
| `password` | User password. | Mandatory | |

## Negotiate and NTLM

Support for Negotiate, Kerberos and NTLM authentication is optional, install with the `windows_auth` extra to enable
this feature.

You can use Negotiate, Kerberos and NTLM authentication with `httpx_auth.Negotiate`.

### Using cached credentials for Kerberos authentication

Cached credentials are used by default for Kerberos authentication, this relies on a Ticket-Granting Ticket being
present on your system from `kinit` or similar. This is supported by default on Windows, on Linux it relies on system
packages being installed. See documentation for the [pyspnego](https://pypi.org/project/pyspnego/) package for more
information.

```python
import httpx
from httpx_auth import Negotiate

with httpx.Client() as client:
client.get('https://www.example.com', auth=Negotiate())
```

### Using provided credentials for NTLM authentication

Where other credentials are required, or if Kerberos is not supported, provide a username and password for
authentication:

```python
import httpx
from httpx_auth import Negotiate

with httpx.Client() as client:
client.get('https://www.example.com', auth=Negotiate('domain\\username', 'password'))
```

### Parameters

| Name | Description | Mandatory | Default value |
|:------------------------|:-----------------------------------------------------------|:----------|:--------------|
| `username` | User name. | Optional | |
| `password` | User password. | Optional | |
| `force_ntlm` | Force the use of NTLM auth | Optional | False |
| `service` | Name portion of the server SPN | Optional | "Service" |
| `max_redirects` | Maximum number of redirects to follow while authenticating | Optional | 10 |

## Multiple authentication at once

You can also use a combination of authentication using `+`or `&` as in the following sample:
Expand Down
1 change: 1 addition & 0 deletions httpx_auth/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
OktaClientCredentials,
OAuth2ResourceOwnerPasswordCredentials,
)
from httpx_auth.negotiate import Negotiate
from httpx_auth.oauth2_tokens import JsonTokenFileCache
from httpx_auth.aws import AWS4Auth
from httpx_auth.errors import (
Expand Down
2 changes: 1 addition & 1 deletion httpx_auth/authentication.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import os
import uuid
from hashlib import sha256, sha512
from urllib.parse import parse_qs, urlsplit, urlunsplit, urlencode
from typing import Optional, Generator
from urllib.parse import parse_qs, urlsplit, urlunsplit, urlencode

import httpx

Expand Down
192 changes: 192 additions & 0 deletions httpx_auth/negotiate.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
import base64
from typing import Generator, List, Optional

import httpx
from httpx_auth.authentication import SupportMultiAuth

try:
import spnego

WINDOWS_AUTH = True
except ImportError:
spnego = None
WINDOWS_AUTH = False


class Negotiate(httpx.Auth, SupportMultiAuth):
"""
NOTE: This does not support Channel Bindings which can (and ought to be) supported by servers. This is due to a
limitation in the HTTPCore library at present.
"""

_username: str
_password: str
force_ntlm: bool
auth_header: str
auth_complete: bool
auth_type: str
_service: str
_context_proxy: "spnego._context.ContextProxy"
max_redirects: int = 10

def __init__(
self,
username: str = None,
password: str = None,
force_ntlm: bool = False,
service: str = None,
max_redirects: int = 10,
) -> None:
"""
:param username: Username and domain (if required). Optional for servers that support Kerberos, required for
those that require NTLM
:param password: Password if required by server for authentication.
:param force_ntlm: Force authentication to use NTLM if available.
:param service: Service portion of the target Service Principal Name (default HTTP)
:return: None
"""
if not WINDOWS_AUTH:
raise ImportError(
"Windows authentication support not enabled, install with the windows_auth extra."
)
if password and not username:
raise ValueError(
"Negotiate authentication with credentials requires username and password, no username was provided."
)
if force_ntlm and not (username and password):
raise ValueError(
"NTLM authentication requires credentials, provide a username and password."
)
self._username = username
self._password = password
self.force_ntlm = force_ntlm
self.auth_header = ""
self.auth_complete = False
self.auth_type = ""
self._service = service
self.max_redirects = max_redirects

def auth_flow(
self, request: httpx.Request
) -> Generator[httpx.Request, httpx.Response, None]:

responses = []
response = yield request
responses.append(response)

redirect_count = 0

# If anything comes back except an authenticate challenge then return it for the client to deal with, hopefully
# a successful response.
if responses[-1].status_code != 401:
return responses[-1]

# Otherwise authenticate. Determine the authentication name to use, prefer Negotiate if available.
self.auth_type = self._auth_type_from_header(
responses[-1].headers.get("WWW-Authenticate")
)
if self.auth_type is None:
return responses[-1]

# Run authentication flow.
yield from self._do_auth_flow(request, responses)

# If we were redirected we will need to rerun the auth flow on the new url, repeat until either we receive a
# status that is not 401 Unauthorized, or until the url we ended up at is the same as the one we requested.
while responses[-1].status_code == 401 and responses[-1].url != request.url:
redirect_count += 1
if redirect_count > self.max_redirects:
raise httpx.TooManyRedirects(
message=f"Redirected too many times ({self.max_redirects}).",
request=request,
)
request.url = responses[-1].url
yield from self._do_auth_flow(request, responses)

return responses[-1]

def _do_auth_flow(
self, request: httpx.Request, responses: List[httpx.Response]
) -> Generator[httpx.Request, httpx.Response, None]:
# Phase 1:
# Configure context proxy, generate message header, attach to request and resend.
host = request.url.host
self.context_proxy = self._new_context_proxy()
self.context_proxy.spn = "{0}/{1}".format(
self._service.upper() if self._service else "HTTP", host
)
request.headers["Authorization"] = self._make_authorization_header(
self.context_proxy.step(None)
)
response = yield request
responses.append(response)

# Phase 2:
# Server responds with Challenge message, parse the authenticate header and deal with cookies. Some web apps use
# cookies to store progress in the auth process.
if "set-cookie" in responses[-1].headers:
request.headers["Cookie"] = responses[-1].headers["set-cookie"]

auth_header_bytes = self._parse_authenticate_header(
responses[-1].headers["WWW-Authenticate"]
)

# Phase 3:
# Generate Authenticate message, attach to the request and resend it. If the user is authorized then this will
# succeed. If not then this will fail.
self.auth_header = self._make_authorization_header(
self.context_proxy.step(auth_header_bytes)
)
request.headers["Authorization"] = self.auth_header
response = yield request
responses.append(response)

def _new_context_proxy(self) -> "spnego._context.ContextProxy":
client = spnego.client(
self._username,
self._password,
service=self._service,
protocol="ntlm" if self.force_ntlm else "negotiate",
)
if self.force_ntlm:
client.options = spnego.NegotiateOptions.use_ntlm
client.protocol = "ntlm"
return client

def _parse_authenticate_header(self, header: str) -> bytes:
"""
Extract NTLM/Negotiate value from Authenticate header and convert to bytes
:param header: str WWW-Authenticate header
:return: bytes Negotiate challenge
"""

auth_strip = self.auth_type.lower() + " "
auth_header_value = next(
s
for s in (val.lstrip() for val in header.split(","))
if s.lower().startswith(auth_strip)
)
return base64.b64decode(auth_header_value[len(auth_strip) :])

def _make_authorization_header(self, response_bytes: bytes) -> str:
"""
Convert the auth bytes to base64 encoded string and build Authorization header.
:param response_bytes: bytes auth response content
:return: str Authorization/Proxy-Authorization header
"""

auth_response = base64.b64encode(response_bytes).decode("ascii")
return f"{self.auth_type} {auth_response}"

@staticmethod
def _auth_type_from_header(header: str) -> Optional[str]:
"""
Given a WWW-Authenticate header, returns the authentication type to use.
:param header: str Authenticate header
:return: Optional[str] Authentication type or None if not supported
"""
if "negotiate" in header.lower():
return "Negotiate"
elif "ntlm" in header.lower():
return "NTLM"
return None
6 changes: 6 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@
"pytest_httpx==0.21.*",
# Used to check coverage
"pytest-cov==3.*",
# Used to test NTLM support
"pytest==6.*",
"pytest-mock==3.6.*"
],
'windows_auth': [
"pyspnego[kerberos]==0.1.6"
]
},
python_requires=">=3.7",
Expand Down
Loading