changed: updated for Elgg 5.1

ColdTrick · Nov 1, 2023 · 8bb6151 · 8bb6151
1 parent cc1f42a
commit 8bb6151
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 31 deletions.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 Questions for Elgg
 ==================
 
-![Elgg 5.0](https://img.shields.io/badge/Elgg-5.0-green.svg)
+![Elgg 5.1](https://img.shields.io/badge/Elgg-5.1-green.svg)
 ![Lint Checks](https://github.com/ColdTrick/questions/actions/workflows/lint.yml/badge.svg?event=push)
 [![Latest Stable Version](https://poser.pugx.org/coldtrick/questions/v/stable.svg)](https://packagist.org/packages/coldtrick/questions)
 [![License](https://poser.pugx.org/coldtrick/questions/license.svg)](https://packagist.org/packages/coldtrick/questions)

diff --git a/classes/ColdTrick/Questions/Cron.php b/classes/ColdTrick/Questions/Cron.php
@@ -23,9 +23,6 @@ public static function autoCloseQuestions(\Elgg\Event $event): void {
 			return;
 		}
 
-		echo 'Starting Questions auto-close processing' . PHP_EOL;
-		elgg_log('Starting Questions auto-close processing', 'NOTICE');
-
 		elgg_call(ELGG_IGNORE_ACCESS, function() use ($auto_close_days) {
 			$site = elgg_get_site_entity();
 
@@ -78,9 +75,6 @@ public static function autoCloseQuestions(\Elgg\Event $event): void {
 				$session_manager->removeLoggedInUser();
 			}
 		});
-
-		echo 'Finished Questions auto-close processing' . PHP_EOL;
-		elgg_log('Finished Questions auto-close processing', 'NOTICE');
 	}
 
 	/**
@@ -96,9 +90,6 @@ public static function notifyQuestionExperts(\Elgg\Event $event): void {
 			return;
 		}
 
-		echo 'Starting Questions experts todo notifications' . PHP_EOL;
-		elgg_log('Starting Questions experts todo notifications', 'NOTICE');
-
 		$time = (int) $event->getParam('time', time());
 
 		// get all experts
@@ -238,8 +229,5 @@ public static function notifyQuestionExperts(\Elgg\Event $event): void {
 		} else {
 			$session_manager->removeLoggedInUser();
 		}
-
-		echo 'Finished Questions experts todo notifications' . PHP_EOL;
-		elgg_log('Finished Questions experts todo notifications', 'NOTICE');
 	}
 }
diff --git a/composer.json b/composer.json
@@ -25,7 +25,7 @@
 		"composer/installers": "^1.0.8"
 	},
 	"conflict": {
-		"elgg/elgg": "<5.0"
+		"elgg/elgg": "<5.1"
 	},
 	"config": {
 		"allow-plugins": {

diff --git a/composer.lock b/composer.lock
diff --git a/views/default/questions/site.css b/views/default/questions/site.css
@@ -1,20 +1,17 @@
-.elgg-menu-item-show-tags {
-	margin-left: auto !important;
-}
-
 .questions-tags-filter {
-
 	> .elgg-menu-container {
 		display: inline-block;
 
-		> .elgg-menu {
-			display: inline-block;
-		}
-	}
-
-	li.elgg-tag {
-		a {
-			line-height: inherit;
+		li.elgg-tag {
+			> a {
+				border: 1px solid $(border-color-soft);
+				border-radius: 3px;
+				padding: 0.25rem 0.5rem;
+
+				&:hover {
+					background-color: $(background-color-soft);
+				 }
+			}
 		}
 	}
 }

diff --git a/views/default/resources/questions/edit.php b/views/default/resources/questions/edit.php
@@ -9,7 +9,7 @@
 /* @var $question \ElggQuestion */
 $question = get_entity($question_guid);
 
-elgg_push_entity_breadcrumbs($question, true);
+elgg_push_entity_breadcrumbs($question);
 
 // build page elements
 $form_vars = [

diff --git a/views/default/resources/questions/view.php b/views/default/resources/questions/view.php
@@ -13,7 +13,7 @@
 $question = get_entity($guid);
 
 // set breadcrumb
-elgg_push_entity_breadcrumbs($question, false);
+elgg_push_entity_breadcrumbs($question);
 
 // build page elements
 $title = $question->getDisplayName();