Gnome 47 #75
Merged
Gnome 47 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloyoyoista
force-pushed
the
gnome-47
branch
from
98e96ac
to
ca73722
Compare
This is mostly relevant when doing API changes on the client, as it simplifies development by much
We stop using "has_management_plugin", since it was remove upstream for packagekit and ostree. Basically since it would be nuts to have this plugin installed alonside any other of those.
Includes a fix for the tests too
Nothing remarkable here
This is a pattern taken from upstream
This function no longer exists!
packagekit plugin is forcing a refine, I wonder if we should too
This is mostly to improve the debugging experience. It is often very useful to run tests with gdb, and the pytest method makes it impossible to do correctly without many changes. By having a wrapper, it is as simple as calling the wrapper with the extra meson arguments
Making it easier to distinguish id and name, and checking it in more places
pabloyoyoista
force-pushed
the
gnome-47
branch
2 times, most recently
from
a11cf4d
to
bee1f54
Compare
pabloyoyoista
force-pushed
the
gnome-47
branch
from
bee1f54
to
279fd48
Compare
By setting the proper list to the task
|
Since nobody reviewed this, and I've given it some testing (fixed one bug), then let's merge this. Would be lovely if somebody could at some point have a look |
|
I'm merging despite the red CI, because it needs apk-polkit-rs patches that are not yet released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch to start fixing #74 in case somebody is following and want to help/have a look