This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Backend changes #275
Merged
Backend changes #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassabreu
approved these changes
Aug 6, 2018
| @@ -34,6 +34,11 @@ func (mailer SendGridMailer) SendEmail(params EmailParams) error { | |||
| to := mail.NewEmail("", params.To) | |||
| message := mail.NewV3MailInit(from, params.Subject, to) | |||
|
|
|||
| if params.CC != "" { | |||
There was a problem hiding this comment.
não seria melhor o CC ser uma lista? []string
There was a problem hiding this comment.
será que vamos ter mais emails em cópia?
There was a problem hiding this comment.
talvez, eh mais uma sugestão... mas realmente não vejo isso acontecer logo
There was a problem hiding this comment.
aham, vamos deixar assim então por enquanto, qualquer coisa alteramos mais tarde. Pode ser?
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 22.88% 22.57% -0.32%
==========================================
Files 26 26
Lines 1302 1320 +18
==========================================
Hits 298 298
- Misses 974 992 +18
Partials 30 30
Continue to review full report at Codecov.
|
|
pode ser |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is connected to a issue?
connected to #271